Add open/close animations to standard button menus + fix menu positioning#326050
Merged
Conversation
hawkticehurst
marked this pull request as draft
July 15, 2026 20:58
Contributor
There was a problem hiding this comment.
Pull request overview
Adds shared open/close motion to standard and rich dropdown menus, gated by Modern UI and reduced-motion preferences.
Changes:
- Applies shared motion defaults to
DropdownMenu. - Adds reusable motion for action-widget dropdowns.
- Migrates chat and extension menus to shared behavior and adds tests.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/vs/base/browser/ui/contextview/contextview.ts |
Exposes shared motion constants and close configuration. |
src/vs/base/browser/ui/dropdown/dropdown.ts |
Applies motion defaults to dropdown menus. |
src/vs/base/test/browser/ui/dropdown/dropdown.test.ts |
Tests default and overridden motion options. |
src/vs/platform/actionWidget/browser/actionWidget.css |
Defines shared action-widget animations. |
src/vs/platform/actionWidget/browser/actionWidgetDropdown.ts |
Adds and applies shared motion options. |
src/vs/platform/actionWidget/test/browser/actionWidgetDropdown.test.ts |
Tests option composition and overrides. |
src/vs/workbench/browser/actions/menuMotion.ts |
Re-exports base motion configuration. |
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPickerActionItem.ts |
Migrates chat pickers to shared motion. |
src/vs/workbench/contrib/chat/browser/widget/media/chat.css |
Removes superseded picker-specific animations. |
src/vs/workbench/contrib/extensions/browser/extensionsActions.ts |
Enables motion for extension management menus. |
hawkticehurst
marked this pull request as ready for review
July 16, 2026 17:17
roblourens
previously approved these changes
Jul 16, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #325020
This pull request implements open/close motion for various sidebar menus in VS Code, following the motion patterns established in previous PRs. Key changes include:
DropdownMenu, affecting sidebar/view toolbars, contributed views, SCM rows, filters, and split installs.withActionWidgetDropdownMotion.workbench.experimental.modernUIsetting and respects reduced motion preferences.New tests have been added to ensure the functionality works as expected, and all changes have been validated through type-checking and live testing.
Screen.Recording.2026-07-16.at.1.08.37.PM.mov
Additionally, fixed an issue where "Manage" icon button menus associated with installed extensions, MCP servers, and Agent plugins were anchored too far from the button.