Skip to content

Add open/close animations to standard button menus + fix menu positioning#326050

Merged
hawkticehurst merged 4 commits into
mainfrom
agents/sidebar-menu-motion-implementation
Jul 16, 2026
Merged

Add open/close animations to standard button menus + fix menu positioning#326050
hawkticehurst merged 4 commits into
mainfrom
agents/sidebar-menu-motion-implementation

Conversation

@hawkticehurst

@hawkticehurst hawkticehurst commented Jul 15, 2026

Copy link
Copy Markdown
Member

Related to #325020

This pull request implements open/close motion for various sidebar menus in VS Code, following the motion patterns established in previous PRs. Key changes include:

  • Menu Animation: Standard button menus now inherit motion globally through the DropdownMenu, affecting sidebar/view toolbars, contributed views, SCM rows, filters, and split installs.
  • Rich Dropdowns: Rich action-widget dropdowns, including the Start Debugging button, utilize shared motion via withActionWidgetDropdownMotion.
  • Legacy Menus: The "Manage" menus in extensions are explicitly bridged to the new motion system.
  • Accessibility: The motion is gated by the workbench.experimental.modernUI setting and respects reduced motion preferences.

New tests have been added to ensure the functionality works as expected, and all changes have been validated through type-checking and live testing.

Screen.Recording.2026-07-16.at.1.08.37.PM.mov

Additionally, fixed an issue where "Manage" icon button menus associated with installed extensions, MCP servers, and Agent plugins were anchored too far from the button.

ui-diff-20260716-131419

Copilot AI review requested due to automatic review settings July 15, 2026 20:57
@hawkticehurst
hawkticehurst marked this pull request as draft July 15, 2026 20:58
@hawkticehurst hawkticehurst self-assigned this Jul 15, 2026
@hawkticehurst hawkticehurst changed the title Add sidebar menu motion for open/close animations [WIP] Add sidebar menu motion for open/close animations Jul 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds shared open/close motion to standard and rich dropdown menus, gated by Modern UI and reduced-motion preferences.

Changes:

  • Applies shared motion defaults to DropdownMenu.
  • Adds reusable motion for action-widget dropdowns.
  • Migrates chat and extension menus to shared behavior and adds tests.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/base/browser/ui/contextview/contextview.ts Exposes shared motion constants and close configuration.
src/vs/base/browser/ui/dropdown/dropdown.ts Applies motion defaults to dropdown menus.
src/vs/base/test/browser/ui/dropdown/dropdown.test.ts Tests default and overridden motion options.
src/vs/platform/actionWidget/browser/actionWidget.css Defines shared action-widget animations.
src/vs/platform/actionWidget/browser/actionWidgetDropdown.ts Adds and applies shared motion options.
src/vs/platform/actionWidget/test/browser/actionWidgetDropdown.test.ts Tests option composition and overrides.
src/vs/workbench/browser/actions/menuMotion.ts Re-exports base motion configuration.
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPickerActionItem.ts Migrates chat pickers to shared motion.
src/vs/workbench/contrib/chat/browser/widget/media/chat.css Removes superseded picker-specific animations.
src/vs/workbench/contrib/extensions/browser/extensionsActions.ts Enables motion for extension management menus.

Comment thread src/vs/platform/actionWidget/browser/actionWidget.css Outdated
@hawkticehurst hawkticehurst changed the title [WIP] Add sidebar menu motion for open/close animations [WIP] Add open/close animations to standard button menus + others Jul 15, 2026
@hawkticehurst hawkticehurst changed the title [WIP] Add open/close animations to standard button menus + others [WIP] Add open/close animations to standard button menus + fix menu positioning Jul 16, 2026
@hawkticehurst
hawkticehurst marked this pull request as ready for review July 16, 2026 17:17
@hawkticehurst hawkticehurst changed the title [WIP] Add open/close animations to standard button menus + fix menu positioning Add open/close animations to standard button menus + fix menu positioning Jul 16, 2026
roblourens
roblourens previously approved these changes Jul 16, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hawkticehurst
hawkticehurst merged commit 789a0c7 into main Jul 16, 2026
29 checks passed
@hawkticehurst
hawkticehurst deleted the agents/sidebar-menu-motion-implementation branch July 16, 2026 18:46
@vs-code-engineering vs-code-engineering Bot added this to the 1.130.0 milestone Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants