agentHost: remove IPC output logging#319224
Draft
roblourens wants to merge 1 commit into
Draft
Conversation
Delete the LoggingAgentConnection wrapper and chat.agentHost.ipcLoggingEnabled setting. Route agent host chat and terminal call sites directly through their IAgentConnection and remove the remote-host Show Output plumbing that only existed for the IPC log channel.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the per-host Agent Host IPC output-channel logging wrapper and routes local/remote chat and terminal integrations directly through IAgentConnection, relying on existing AHP JSONL and forwarded log surfaces for diagnostics.
Changes:
- Removed
LoggingAgentConnectionand thechat.agentHost.ipcLoggingEnabledsetting. - Updated local and remote chat/terminal registration paths to pass raw
IAgentConnectioninstances. - Removed remote-host “Show Output” plumbing and related provider API/documentation references.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Removes configuration registration for IPC output logging. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/loggingAgentConnection.ts |
Deletes the IPC output-channel logging wrapper. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostTerminalContribution.ts |
Uses the local agent host service directly for terminal connections. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatContribution.ts |
Uses the local agent host service directly for chat/session/auth flows. |
src/vs/sessions/contrib/providers/remoteAgentHost/REMOTE_AGENT_HOST_SESSIONS_PROVIDER.md |
Updates provider documentation to reflect removal of IPC output-channel management. |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteHostOptions.ts |
Removes the remote-host “Show Output” option and output service dependency. |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostTerminal.contribution.ts |
Uses remote connections directly for terminal entries. |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostSessionsProvider.ts |
Removes stored output-channel ID from the sessions provider. |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHost.contribution.ts |
Reworks remote connection state and registration to use raw IAgentConnection. |
src/vs/sessions/common/agentHostSessionsProvider.ts |
Removes output-channel ID from the shared provider interface. |
src/vs/platform/agentHost/common/agentService.ts |
Removes the IPC logging setting constant. |
Copilot's findings
- Files reviewed: 11/11 changed files
- Comments generated: 1
Comment on lines
51
to
52
| /** Configuration key that controls whether AHP JSONL logs are written for agent host transports. */ | ||
| export const AgentHostAhpJsonlLoggingSettingId = 'chat.agentHost.ahpJsonlLoggingEnabled'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
(Written by Copilot)