chat: support queue priority context actions for pending requests (#305683)#319164
Open
Neizan93 wants to merge 3 commits into
Open
chat: support queue priority context actions for pending requests (#305683)#319164Neizan93 wants to merge 3 commits into
Neizan93 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds UI affordances and implementation to reprioritize pending chat requests from the chat context menu, and improves notification toast dismissal UX with a fade-out transition.
Changes:
- Added chat context keys and menu actions to move pending requests up/down/top/bottom in the queue
- Extended chat list context-menu overlay to expose “first/last pending request” state
- Implemented fade-out removal for notification toasts (with reduced-motion handling)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/actions/chatQueueActions.ts | Adds 4 new queue reordering actions and registers them. |
| src/vs/workbench/contrib/chat/browser/widget/chatListWidget.ts | Computes first/last pending request and exposes new context keys for menus. |
| src/vs/workbench/contrib/chat/common/actions/chatContextKeys.ts | Introduces new context keys for first/last pending request. |
| src/vs/workbench/contrib/chat/test/browser/actions/chatQueueActions.test.ts | Adds execution tests for the new queue reordering actions. |
| src/vs/workbench/browser/parts/notifications/notificationsToasts.ts | Adds fade-out removal flow and guards against duplicate removals. |
| src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css | Adds CSS for the fade-out transition (and reduce-motion override). |
Neizan93
force-pushed
the
feature/chat-queue-priority-305683
branch
from
9718c8b to
e260798
Compare
Neizan93
force-pushed
the
feature/chat-queue-priority-305683
branch
from
e260798 to
0e3602d
Compare
Neizan93
force-pushed
the
feature/chat-queue-priority-305683
branch
from
0e3602d to
eb136d1
Compare
Neizan93
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #305683
Description
This PR implements context menu options to manage queue priority for pending/queued chat requests in the VS Code Chat interface.
Users can now right-click a queued/pending request and choose:
Proposed Changes
chatRequestIsFirstPendingandchatRequestIsLastPendinginchatContextKeys.ts.handleContextMenuinchatListWidget.tsto dynamically calculate the request's position in the queue of pending requests, overlaying position keys on the context key service.ChatMovePendingRequestUpAction, etc.) inchatQueueActions.tsunder the'queue_priority'menu group forMenuId.ChatContext.whenclauses so actions only appear on pending request items and respect queue limits (e.g. "Move Up" and "Move to Top" are hidden on the first queued request, and "Move Down" and "Move to Bottom" are hidden on the last one).chatQueueActions.test.tsverifying correct order manipulation under mock widgets/services. UsedensureNoDisposablesAreLeakedInTestSuite()to guarantee no memory leak introduction.