feat: add PromptExtensionInstallFailureAction to handle extension ins…#319150
Open
vishalranaut wants to merge 2 commits into
Open
feat: add PromptExtensionInstallFailureAction to handle extension ins…#319150vishalranaut wants to merge 2 commits into
vishalranaut wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Filters hidden actions from the Manage Extension dropdown menu and removes any resulting empty groups.
Changes:
- Apply hidden-action filtering to each group in
getActionGroups - Drop groups that become empty after filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove duplicate disable options in extension button dropdown
Fixes #244138
Problem
When a VS Code extension is disabled both globally and for the workspace, the "Disable" button dropdown incorrectly shows both options at the same time:
This is confusing because one or both states are already applied — showing them again implies the user can disable something that is already disabled.
Root cause
The dropdown action list was being built without checking the extension's current disabled state. Both actions were always added regardless of whether the extension was already globally disabled, workspace-disabled, or enabled.
Fix
Added conditional checks before pushing each action into the dropdown list:
File changed:
src/vs/workbench/contrib/extensions/browser/extensionsActions.tsBefore
Dropdown always showed both "Disable" and "Disable (Workspace)" regardless of state.
After
Dropdown only shows the disable options that are actually applicable to the current extension state.
Checklist