Skip to content

Lay out webview view after claim to avoid flash in wrong area #310204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yogeshwaran-c wants to merge 1 commit into from
+9 −0
Closed

Lay out webview view after claim to avoid flash in wrong area #310204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/vs/workbench/contrib/webviewView/browser/webviewViewPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,15 @@ export class WebviewViewPane extends ViewPane {
if (this.isBodyVisible()) {
this.activate();
this._webview.value?.claim(this, getWindow(this.element), undefined);
// Lay out the webview immediately after claiming so that it is
// positioned over the current view container before the next paint.
// Without this, the overlay container may briefly become visible at
// stale coordinates from a previous layout (for example, when the
// pane was last shown in a different part of the workbench), causing
// a one-frame flash in the wrong location. See #243038.
if (this._container) {
this.layoutWebview();
}
} else {
this._webview.value?.release(this);
}
Expand Down