fix: make protected members public to resolve mangler build errors#310195
Open
NikolaRHristov wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: make protected members public to resolve mangler build errors#310195NikolaRHristov wants to merge 2 commits intomicrosoft:mainfrom
NikolaRHristov wants to merge 2 commits intomicrosoft:mainfrom
Conversation
`setEditorVisible` in `editorPane.ts` and `_enableCommandLineSandboxRewriting` in `runInTerminalTool.ts` were declared as `protected` but accessed publicly by subclasses (`chatDebugEditor.ts` and `runInTerminalConfirmationTool.ts` respectively), causing the mangler to promote them to public and then error with "Protected fields have been made PUBLIC". Explicitly mark both members as `public` to satisfy the mangler and allow `compile-build-with-mangling` to complete successfully. Fixes microsoft#310191
Author
|
@microsoft-github-policy-service agree company="PlayForm" |
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Member
|
@NikolaRHristov thanks for opening a PR, I think we should just add |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setEditorVisibleineditorPane.tsand_enableCommandLineSandboxRewritinginrunInTerminalTool.tswere declared asprotectedbut accessed publicly by subclasses (chatDebugEditor.tsandrunInTerminalConfirmationTool.tsrespectively), causing the mangler to promote them to public and then error with "Protected fields have been made PUBLIC".Explicitly mark both members as
publicto satisfy the mangler and allowcompile-build-with-manglingto complete successfully.Fixes #310191