Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Electron dependency to 39.8.7 and aligns VS Code/Copilot code with upstream TLS API changes (removing usage/telemetry around tls.getSystemCACertificatesErrors).
Changes:
- Bump Electron from 39.8.5 → 39.8.7 and update associated manifests/locks/checksums.
- Remove additional certificates telemetry field and related helper logic tied to the removed TLS errors API.
- Simplify Copilot’s “show Node.js system certificate errors” diagnostics command implementation.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/api/node/proxyResolver.ts | Removes nodeSystemCertErrors telemetry + helper that depended on the removed TLS errors API. |
| extensions/copilot/src/extension/log/vscode-node/loggingActions.ts | Drops collection/display of TLS system CA certificate errors in the diagnostics command. |
| package.json | Updates Electron version to 39.8.7. |
| package-lock.json | Updates Electron lockfile entry to 39.8.7. |
| cgmanifest.json | Updates Electron component metadata (tag/hash/version) to 39.8.7. |
| build/checksums/electron.txt | Refreshes Electron/Chromedriver/FFmpeg/etc. checksums for 39.8.7 artifacts. |
| .npmrc | Updates Electron build target/version and ms_build_id. |
chrmarti
reviewed
Apr 10, 2026
Collaborator
chrmarti
left a comment
There was a problem hiding this comment.
The command could be remove, otherwise LGTM, thanks!
chrmarti
previously approved these changes
Apr 10, 2026
joaomoreno
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://releases.electronjs.org/release/compare/v39.8.5/v39.8.7
tls.getSystemCACertificatesErrorsapi as the relevant issues were identified and resolved cc @chrmarti