Skip to content

chore: update electron@39.8.7#308959

Merged
deepak1556 merged 4 commits intomainfrom
robo/update_electron
Apr 10, 2026
Merged

chore: update electron@39.8.7#308959
deepak1556 merged 4 commits intomainfrom
robo/update_electron

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

Refs https://releases.electronjs.org/release/compare/v39.8.5/v39.8.7

@deepak1556 deepak1556 added this to the 1.116.0 milestone Apr 10, 2026
@deepak1556 deepak1556 self-assigned this Apr 10, 2026
Copilot AI review requested due to automatic review settings April 10, 2026 07:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s Electron dependency to 39.8.7 and aligns VS Code/Copilot code with upstream TLS API changes (removing usage/telemetry around tls.getSystemCACertificatesErrors).

Changes:

  • Bump Electron from 39.8.5 → 39.8.7 and update associated manifests/locks/checksums.
  • Remove additional certificates telemetry field and related helper logic tied to the removed TLS errors API.
  • Simplify Copilot’s “show Node.js system certificate errors” diagnostics command implementation.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/workbench/api/node/proxyResolver.ts Removes nodeSystemCertErrors telemetry + helper that depended on the removed TLS errors API.
extensions/copilot/src/extension/log/vscode-node/loggingActions.ts Drops collection/display of TLS system CA certificate errors in the diagnostics command.
package.json Updates Electron version to 39.8.7.
package-lock.json Updates Electron lockfile entry to 39.8.7.
cgmanifest.json Updates Electron component metadata (tag/hash/version) to 39.8.7.
build/checksums/electron.txt Refreshes Electron/Chromedriver/FFmpeg/etc. checksums for 39.8.7 artifacts.
.npmrc Updates Electron build target/version and ms_build_id.

Comment thread extensions/copilot/src/extension/log/vscode-node/loggingActions.ts Outdated
Copy link
Copy Markdown
Collaborator

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command could be remove, otherwise LGTM, thanks!

Comment thread extensions/copilot/src/extension/log/vscode-node/loggingActions.ts Outdated
chrmarti
chrmarti previously approved these changes Apr 10, 2026
@deepak1556 deepak1556 merged commit c88afda into main Apr 10, 2026
26 checks passed
@deepak1556 deepak1556 deleted the robo/update_electron branch April 10, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants