Fix hidden + button in inline chat#297072
Merged
daviddossett merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI bug where the + (Add Context) button in inline chat was being hidden in the overflow menu. The issue occurred because both the Chat sidebar and EditorInline locations shared order: 101, causing the button to be hidden first in the narrow inline chat toolbar due to its responsive overflow behavior.
Changes:
- Split the
AttachContextActionmenu registration from a single entry with location condition to two separate entries - Chat sidebar entry keeps
order: 101(unchanged) - EditorInline entry now uses
order: 2(new), positioning it between the mode picker and model picker
daviddossett
changed the title
+ button in inline chat
hediet
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
+(Add Context) button in inline chat was being pushed into the overflow...menu because it sharedorder: 101with the sidebar chat registration. Since the inline chat toolbar is narrow and uses responsive behavior that hides items from the right, the+button — being the highest-ordered item — was hidden first.Fix: Split the
AttachContextActionmenu registration into separate entries for Chat sidebar (order: 101, unchanged) and EditorInline (order: 2), so the+button appears before the model picker and tools actions in inline chat and stays visible.Fixes #297051