Conversation
There was a problem hiding this comment.
Pull request overview
This PR moves component fixture screenshot baseline PNGs to Git LFS and configures Git attributes so future changes to these screenshots are stored as LFS objects instead of regular Git blobs.
Changes:
- Add Git LFS pointer files for existing/new screenshot baselines under
test/componentFixtures/.screenshots/baseline/**. - Configure
.gitattributesto tracktest/componentFixtures/.screenshots/**/*.pngvia Git LFS.
Reviewed changes
Copilot reviewed 1 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.gitattributes |
Adds Git LFS tracking rule for test/componentFixtures/.screenshots/**/*.png. |
test/componentFixtures/.screenshots/baseline/inlineCompletions/WordReplacementView/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/inlineCompletions/WordReplacementView/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/inlineCompletions/SideBySideView/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/inlineCompletions/SideBySideView/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/inlineCompletions/InsertionView/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/inlineCompletions/InsertionView/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/codeEditor/CodeEditor/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/codeEditor/CodeEditor/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/Toggles/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/Toggles/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/ProgressBars/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/ProgressBars/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/InputBoxes/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/InputBoxes/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/HighlightedLabels/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/HighlightedLabels/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/CountBadges/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/CountBadges/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/Buttons/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/Buttons/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/ButtonBar/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/ButtonBar/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/ActionBar/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/baseUI/ActionBar/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHoverNoData/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHoverNoData/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHover/Light.png |
Baseline screenshot stored as a Git LFS pointer. |
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHover/Dark.png |
Baseline screenshot stored as a Git LFS pointer. |
| *.rtf -text | ||
| **/*.json linguist-language=jsonc | ||
|
|
||
| test/componentFixtures/.screenshots/**/*.png filter=lfs diff=lfs merge=lfs -text |
There was a problem hiding this comment.
Tracking these baseline screenshots via Git LFS will cause checkouts that don’t fetch LFS objects (e.g. .github/workflows/screenshot-test.yml uses actions/checkout without lfs: true) to only have the pointer text files instead of real PNGs, which will break screenshot comparison (and any local dev without git-lfs). Please update the relevant CI checkout steps to fetch LFS objects (or run git lfs install + git lfs pull) and consider documenting the git-lfs requirement for contributors running screenshot tests.
| test/componentFixtures/.screenshots/**/*.png filter=lfs diff=lfs merge=lfs -text | |
| test/componentFixtures/.screenshots/**/*.png -text |
|
@copilot please address the feedback. only the screenshot ci needs them though |
No description provided.