Skip to content

Comments

use git lfs#297013

Merged
hediet merged 1 commit intomainfrom
hediet/b/bumpy-dragonfly
Feb 23, 2026
Merged

use git lfs#297013
hediet merged 1 commit intomainfrom
hediet/b/bumpy-dragonfly

Conversation

@hediet
Copy link
Member

@hediet hediet commented Feb 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 23, 2026 15:37
@hediet hediet enabled auto-merge (squash) February 23, 2026 15:37
@hediet hediet self-assigned this Feb 23, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves component fixture screenshot baseline PNGs to Git LFS and configures Git attributes so future changes to these screenshots are stored as LFS objects instead of regular Git blobs.

Changes:

  • Add Git LFS pointer files for existing/new screenshot baselines under test/componentFixtures/.screenshots/baseline/**.
  • Configure .gitattributes to track test/componentFixtures/.screenshots/**/*.png via Git LFS.

Reviewed changes

Copilot reviewed 1 out of 29 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.gitattributes Adds Git LFS tracking rule for test/componentFixtures/.screenshots/**/*.png.
test/componentFixtures/.screenshots/baseline/inlineCompletions/WordReplacementView/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/inlineCompletions/WordReplacementView/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/inlineCompletions/SideBySideView/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/inlineCompletions/SideBySideView/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/inlineCompletions/InsertionView/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/inlineCompletions/InsertionView/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/codeEditor/CodeEditor/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/codeEditor/CodeEditor/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/Toggles/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/Toggles/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/ProgressBars/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/ProgressBars/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/InputBoxes/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/InputBoxes/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/HighlightedLabels/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/HighlightedLabels/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/CountBadges/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/CountBadges/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/Buttons/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/Buttons/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/ButtonBar/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/ButtonBar/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/ActionBar/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/baseUI/ActionBar/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHoverNoData/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHoverNoData/Dark.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHover/Light.png Baseline screenshot stored as a Git LFS pointer.
test/componentFixtures/.screenshots/baseline/aiStats/AiStatsHover/Dark.png Baseline screenshot stored as a Git LFS pointer.

*.rtf -text
**/*.json linguist-language=jsonc

test/componentFixtures/.screenshots/**/*.png filter=lfs diff=lfs merge=lfs -text
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking these baseline screenshots via Git LFS will cause checkouts that don’t fetch LFS objects (e.g. .github/workflows/screenshot-test.yml uses actions/checkout without lfs: true) to only have the pointer text files instead of real PNGs, which will break screenshot comparison (and any local dev without git-lfs). Please update the relevant CI checkout steps to fetch LFS objects (or run git lfs install + git lfs pull) and consider documenting the git-lfs requirement for contributors running screenshot tests.

Suggested change
test/componentFixtures/.screenshots/**/*.png filter=lfs diff=lfs merge=lfs -text
test/componentFixtures/.screenshots/**/*.png -text

Copilot uses AI. Check for mistakes.
@hediet
Copy link
Member Author

hediet commented Feb 23, 2026

@copilot please address the feedback. only the screenshot ci needs them though

Copy link
Contributor

Copilot AI commented Feb 23, 2026

@hediet I've opened a new pull request, #297014, to work on those changes. Once the pull request is ready, I'll request review from you.

@hediet hediet merged commit 2650c90 into main Feb 23, 2026
24 checks passed
@hediet hediet deleted the hediet/b/bumpy-dragonfly branch February 23, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants