Hide manage model picker action item when required#296876
Draft
DonJayamanne wants to merge 1 commit intomainfrom
Draft
Hide manage model picker action item when required#296876DonJayamanne wants to merge 1 commit intomainfrom
DonJayamanne wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a canManageModels parameter to conditionally control the visibility of the "Manage Models..." action item in the chat model picker. This allows the model picker to hide the management option when used in specific contexts, such as sessions with specialized model requirements (indicated by getCurrentSessionType()).
Changes:
- Added
canManageModels: booleanparameter tobuildModelPickerItemsfunction - Modified conditional logic to check
canManageModelsbefore displaying the "Manage Models..." entry and its preceding separator - Updated all test call sites and added comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Added canManageModels parameter to buildModelPickerItems function and updated conditional logic to respect this flag when showing the "Manage Models..." action |
| src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts | Updated test helper function to accept canManageModels option, added 6 new tests covering various scenarios, and updated existing direct call sites to pass true explicitly |
a434da8 to
b99552b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.