Skip to content

Comments

simple terminal tools on surface level of chat#296870

Merged
justschen merged 3 commits intomainfrom
justin/petilil
Feb 23, 2026
Merged

simple terminal tools on surface level of chat#296870
justschen merged 3 commits intomainfrom
justin/petilil

Conversation

@justschen
Copy link
Collaborator

Screen.Recording.2026-02-22.at.11.52.38.AM.1.mov
Screenshot 2026-02-22 at 11 54 02 AM 548-Petilil

Copilot AI review requested due to automatic review settings February 22, 2026 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an experimental setting to render terminal tool invocations in a simplified collapsible UI outside of “thinking”, enabling a more compact surface-level presentation in chat.

Changes:

  • Introduces a new configuration key chat.tools.terminal.simpleCollapsible (ChatConfiguration.SimpleTerminalCollapsible).
  • Registers the new setting in the chat configuration contribution.
  • Updates ChatTerminalToolProgressPart to wrap terminal tool calls in the collapsible wrapper when the new setting is enabled.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/chat/common/constants.ts Adds the ChatConfiguration.SimpleTerminalCollapsible enum value.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts Uses the new setting to decide whether terminal tool invocations render inside a collapsible wrapper.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Registers the new experimental boolean setting and its description.

Copy link
Contributor

Copilot AI commented Feb 23, 2026

@justschen I've opened a new pull request, #296911, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits February 22, 2026 22:43
…able (#296911)

* Initial plan

* Set SimpleTerminalCollapsible default true for insiders, false for stable

Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>
@justschen justschen marked this pull request as ready for review February 23, 2026 19:10
@justschen justschen enabled auto-merge (squash) February 23, 2026 19:10
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 23, 2026
@justschen justschen merged commit 096c9b7 into main Feb 23, 2026
20 checks passed
@justschen justschen deleted the justin/petilil branch February 23, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants