Avoid getItemsWidth on chat toolbars when it's not actually used#286946
Merged
roblourens merged 1 commit intomainfrom Jan 10, 2026
Merged
Avoid getItemsWidth on chat toolbars when it's not actually used#286946roblourens merged 1 commit intomainfrom
roblourens merged 1 commit intomainfrom
Conversation
re: #286531 already fixed but this would improve this and all other layout scenarios
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the layout performance of the chat input by deferring expensive toolbar width calculations until they are actually needed.
Changes:
- Wrapped expensive
getItemsWidth()calls in a lazily-evaluated function that only executes whenrenderStyle === 'compact' - Prevents layout thrashing during typing by avoiding unnecessary DOM measurements when toolbar width is not used (when result would be 0)
Tyriar
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: #286531 already fixed but this would improve this and all other layout scenarios