-
Notifications
You must be signed in to change notification settings - Fork 37.3k
Add support for custom source grouping #286453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aeschli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be rather be done as a label on the provider.
How do you see the label being used? I guess in the current UX, we have fixed categories like Extensions, Workspace etc. On top of this broader categorization, we could have some way to filter based on the provided label maybe? |
|
I liked the way you proposed it in the screenshot. If a provider has a label, use it as category, if not, thing go to 'Extensions'. That can lead to potentially many categories so we have to see, but at least for the ones we contribute we can make sure we reuse Categories. |
I think I'd like to hold off on making the label public part of contract since like you said we can end up with a mess if each extension tries to create their own convention. We can still keep it on the provider as private? We can most likely extend the contracts as needed if/when our UX makes this distinction more useful. Let me know what you think! |
Fixes #280798