Skip to content

Conversation

@pwang347
Copy link
Member

@pwang347 pwang347 commented Jan 7, 2026

image

Fixes #280798

@pwang347 pwang347 changed the title add support for custom source grouping Add support for custom source grouping Jan 7, 2026
Copy link
Contributor

@aeschli aeschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be rather be done as a label on the provider.

@pwang347
Copy link
Member Author

pwang347 commented Jan 8, 2026

I wonder if this should be rather be done as a label on the provider.

How do you see the label being used? I guess in the current UX, we have fixed categories like Extensions, Workspace etc. On top of this broader categorization, we could have some way to filter based on the provided label maybe?

@aeschli
Copy link
Contributor

aeschli commented Jan 9, 2026

I liked the way you proposed it in the screenshot. If a provider has a label, use it as category, if not, thing go to 'Extensions'. That can lead to potentially many categories so we have to see, but at least for the ones we contribute we can make sure we reuse Categories.
We might need to add the category to the existing (static) contribution points.

Base automatically changed from pawang/orgInstructions to main January 9, 2026 19:30
@pwang347
Copy link
Member Author

pwang347 commented Jan 10, 2026

I liked the way you proposed it in the screenshot. If a provider has a label, use it as category, if not, thing go to 'Extensions'. That can lead to potentially many categories so we have to see, but at least for the ones we contribute we can make sure we reuse Categories. We might need to add the category to the existing (static) contribution points.

I think I'd like to hold off on making the label public part of contract since like you said we can end up with a mess if each extension tries to create their own convention. We can still keep it on the provider as private? We can most likely extend the contracts as needed if/when our UX makes this distinction more useful. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distinguish where the enterprise agent mode comes from

3 participants