Fix passing parameter enabledApiProposalsJson #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bschnurr
commented
Jan 23, 2026
bschnurr
commented
- publish was failing complaining '--allow-proposed-apis' flags still missing.
Added env: EnabledApiProposalsJson: ${{ parameters.enabledApiProposalsJson }} on the PowerShell@2 step.
Script continues to read $env:EnabledApiProposalsJson (safe for JSON with quotes).
publish-extension.yml
Wired it up: enabledApiProposalsJson: $(EnabledApiProposalsJson) when calling the publish template.
This should fully eliminate the PowerShell parser failure you hit while still allowing the --allow-proposed-apis ... list to be applied when present.
…the publish script was turning the JSON into a nested array and then joining/printing it poorly — which then produced an invalid CLI arg: --allow-proposed-apis System.Object[]. I’ve fixed that parsing/flattening in publish.yml, so the publish log should now show: enabledApiProposals (from EnabledApiProposalsJson): portsAttributes, debugVisualization, contribViewsWelcome and the npx ... publish command should include: --allow-proposed-apis portsAttributes debugVisualization contribViewsWelcome
rchiodo
approved these changes
Jan 23, 2026
StellaHuang95
approved these changes
Jan 23, 2026
bschnurr
added
the
debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.