Skip to content

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Jan 9, 2026

Fixes #8380

Copilot AI review requested due to automatic review settings January 9, 2026 10:07
@alexr00 alexr00 enabled auto-merge (squash) January 9, 2026 10:07
@alexr00 alexr00 self-assigned this Jan 9, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent notifications from being created for Copilot PRs that are in progress (i.e., have a "Started" status), addressing issue #8380.

Key Changes

  • Added a check in CopilotStateModel.set() to skip notification creation for PRs with Started status
  • State changes are still tracked, but notifications are suppressed for in-progress PRs
Comments suppressed due to low confidence (1)

src/github/copilotPrWatcher.ts:74

  • This change modifies existing notification behavior. The existing test at line 61-63 in copilotPrWatcher.test.ts expects notifications to be created when a PR status changes to Started after initialization. This breaking change requires updating the test expectations to reflect the new behavior where Started status should not generate notifications.
			if ((currentStatus?.status === CopilotPRStatus.Started)) {
				continue;
			}

@dmitrivMS
Copy link

Does AI have good points here? Also CI is failing...

Tyriar
Tyriar previously approved these changes Jan 9, 2026
Copy link
Member Author

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot feedback was legit.

Copilot AI review requested due to automatic review settings January 9, 2026 13:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

dmitrivMS
dmitrivMS previously approved these changes Jan 9, 2026
@alexr00
Copy link
Member Author

alexr00 commented Jan 9, 2026

@microsoft-github-policy-service rerun

@alexr00 alexr00 disabled auto-merge January 9, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not create notifications for copilot PRs which are in progress

4 participants