-
Notifications
You must be signed in to change notification settings - Fork 704
Do not create notifications for copilot PRs which are in progress #8381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to prevent notifications from being created for Copilot PRs that are in progress (i.e., have a "Started" status), addressing issue #8380.
Key Changes
- Added a check in
CopilotStateModel.set()to skip notification creation for PRs with Started status - State changes are still tracked, but notifications are suppressed for in-progress PRs
Comments suppressed due to low confidence (1)
src/github/copilotPrWatcher.ts:74
- This change modifies existing notification behavior. The existing test at line 61-63 in copilotPrWatcher.test.ts expects notifications to be created when a PR status changes to Started after initialization. This breaking change requires updating the test expectations to reflect the new behavior where Started status should not generate notifications.
if ((currentStatus?.status === CopilotPRStatus.Started)) {
continue;
}
|
Does AI have good points here? Also CI is failing... |
alexr00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot feedback was legit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
|
@microsoft-github-policy-service rerun |
Fixes #8380