Code Analysis: PR2 - Initial Code Analysis dialog setup: React view, state wiring, and controller integration by ssreerama · Pull Request #21270 · microsoft/vscode-mssql

ssreerama · 2026-02-19T19:18:30Z

Description

This PR Adds:

This PR delivers the initial Code Analysis dialog scaffold with a minimal, iterative-first implementation focused on UI and wiring, without backend save/apply behavior.
React dialog view structure for Code Analysis configuration.
State management setup for loading and rendering rules in the dialog.
Webview controller integration to open/initialize the dialog flow.
Shared contracts and message flow alignment between controller and webview.
Localization hookup for dialog labels/actions.
UX consistency alignment with existing dialog/table patterns.
Added Icon for the dialog tab and header
Added couple of basic tests to validate the dialog

Code Changes Checklist

New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copilot

Pull request overview

This PR adds the initial scaffold for a Code Analysis configuration dialog in the mssql extension. The implementation follows an iterative-first approach, focusing on UI structure and state wiring without backend save/apply functionality, as stated in the PR description. The dialog allows users to view code analysis rules for SQL database projects with a table-based interface showing rule status, severity, and enabled state.

Changes:

Added React-based Code Analysis dialog with table view for displaying SQL code analysis rules
Integrated webview controller with telemetry and state management
Added localization support for dialog labels and messages
Added SVG icons for light and dark themes
Registered command handler in mainController and integrated with sql-database-projects extension

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts	New controller managing the Code Analysis webview, state, and RPC handlers with placeholder rule loading
extensions/mssql/src/sharedInterfaces/codeAnalysis.ts	Type definitions for Code Analysis state, rules, reducers, and provider interface
extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx	React component implementing the dialog UI with rules table and action buttons
extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysisStateProvider.tsx	React context provider for managing Code Analysis state and webview RPC
extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysisSelector.ts	Custom hook for selecting Code Analysis state slices
extensions/mssql/src/reactviews/pages/CodeAnalysis/index.tsx	Entry point for rendering the Code Analysis page with providers
extensions/mssql/src/reactviews/common/locConstants.ts	Added codeAnalysis localization section and common.save string
extensions/mssql/src/constants/locConstants.ts	Added CodeAnalysis.Title localization constant
extensions/mssql/src/constants/constants.ts	Added command constant and view ID for Code Analysis
extensions/mssql/src/enums.ts	Added RuleSeverity enum for code analysis severity levels
extensions/mssql/src/controllers/mainController.ts	Registered configureCodeAnalysisSettings command handler
extensions/mssql/src/sharedInterfaces/telemetry.ts	Added telemetry actions for Code Analysis dialog events
extensions/mssql/test/unit/codeAnalysisWebViewController.test.ts	Basic unit tests for controller initialization and icon paths
extensions/mssql/scripts/bundle-reactviews.js	Added codeAnalysis entry point to build configuration
extensions/mssql/media/codeAnalysis_light.svg	Light theme icon for Code Analysis dialog
extensions/mssql/media/codeAnalysis_dark.svg	Dark theme icon for Code Analysis dialog
localization/xliff/vscode-mssql.xlf	Added localization entries for Code Analysis strings
extensions/mssql/l10n/bundle.l10n.json	Added/reorganized localization strings including Code Analysis entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-19T19:28:36Z

PR Changes

Category	Target Branch	PR Branch	Difference
vscode-mssql VSIX	6114 KB	6119 KB	⚪ 5 KB ( 0% )
sql-database-projects VSIX	7027 KB	7027 KB	⚪ 0 KB ( 0% )
data-workspace VSIX	535 KB	535 KB	⚪ 0 KB ( 0% )

codecov-commenter · 2026-02-19T19:52:52Z

Codecov Report

❌ Patch coverage is 85.30806% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.88%. Comparing base (1727a64) to head (02f73b8).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
extensions/mssql/src/controllers/mainController.ts	33.33%	18 Missing ⚠️
...nsions/mssql/src/reactviews/common/locConstants.ts	63.88%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21270      +/-   ##
==========================================
+ Coverage   71.84%   71.88%   +0.04%     
==========================================
  Files         281      283       +2     
  Lines       90090    90333     +243     
  Branches     4648     4651       +3     
==========================================
+ Hits        64722    64934     +212     
- Misses      25368    25399      +31

Files with missing lines	Coverage Δ
.../src/codeAnalysis/codeAnalysisWebViewController.ts	`100.00% <100.00%> (ø)`
extensions/mssql/src/constants/constants.ts	`100.00% <100.00%> (ø)`
extensions/mssql/src/constants/locConstants.ts	`74.98% <100.00%> (+0.03%)`	⬆️
extensions/mssql/src/enums.ts	`100.00% <100.00%> (ø)`
extensions/mssql/src/sharedInterfaces/telemetry.ts	`100.00% <100.00%> (ø)`
...nsions/mssql/src/reactviews/common/locConstants.ts	`21.74% <63.88%> (+0.65%)`	⬆️
extensions/mssql/src/controllers/mainController.ts	`29.42% <33.33%> (+0.03%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…euse the existing consts

…rements

Copilot

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ssreerama added 7 commits February 19, 2026 12:04

intial changes

edd32ac

loc

c4dbafc

adding test file and basic tests

e0c6728

LOC

9d971c4

reuse existing loc constants

234fbdb

loc

58d024d

enable dd for now

3da01a8

Copilot AI review requested due to automatic review settings February 19, 2026 19:18

ssreerama requested review from Benjin, aasimkhan30, allancascante, caohai, kburtram, laurenastrid1, lewis-sanchez and manujoseph85 as code owners February 19, 2026 19:18

Copilot started reviewing on behalf of ssreerama February 19, 2026 19:19 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

ssreerama added 2 commits February 19, 2026 13:58

applying copiot review changes

a322263

loc

6635027

ssreerama requested a review from Copilot February 19, 2026 20:00

Copilot started reviewing on behalf of ssreerama February 19, 2026 20:01 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Comment thread extensions/mssql/src/codeAnalysis/codeAnalysisWebViewController.ts

Comment thread extensions/mssql/test/unit/codeAnalysisWebViewController.test.ts Outdated

Comment thread extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx Outdated

ssreerama added 2 commits February 19, 2026 14:58

wrong button name and dd values used

954ef63

fixing comments

99040b4

Copilot AI review requested due to automatic review settings February 19, 2026 21:59

Copilot started reviewing on behalf of ssreerama February 19, 2026 22:00 View session

ssreerama changed the title ~~Code Anlysis: PR2 - Initial Code Analysis dialog setup: React view, state wiring, and controller integration~~ Code Analysis: PR2 - Initial Code Analysis dialog setup: React view, state wiring, and controller integration Feb 19, 2026

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Merge branch 'main' into sai/mar/codeAnalysis_mssqlSampleDialog

b2e5257

ssreerama self-assigned this Feb 20, 2026

ssreerama added the Area - SQL Project label Feb 20, 2026

ssreerama added this to the March 2026 Release milestone Feb 20, 2026

ssreerama requested a review from Copilot February 20, 2026 23:28

Copilot started reviewing on behalf of ssreerama February 20, 2026 23:28 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

ssreerama added 5 commits February 23, 2026 09:59

Merge branch 'main' into sai/mar/codeAnalysis_mssqlSampleDialog

c796e91

adding area-label to the checkbox and dropdown and also making sure r…

0b65395

…euse the existing consts

loc

0b9939f

refactoring the table structure as per the code analysis dialog requi…

f9ebbb3

…rements

loc

007bf71

ssreerama requested a review from Copilot February 23, 2026 16:45

Copilot started reviewing on behalf of ssreerama February 23, 2026 16:46 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

ssreerama requested a review from Copilot February 23, 2026 17:40

Copilot started reviewing on behalf of ssreerama February 23, 2026 17:41 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

Comment thread extensions/mssql/src/sharedInterfaces/codeAnalysis.ts

Comment thread extensions/mssql/src/reactviews/pages/CodeAnalysis/codeAnalysis.tsx

test fix

02f73b8

ssreerama requested a review from Copilot February 23, 2026 18:19

Copilot started reviewing on behalf of ssreerama February 23, 2026 18:20 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

aasimkhan30 approved these changes Feb 23, 2026

View reviewed changes

ssreerama merged commit 61371f5 into main Feb 23, 2026
7 checks passed

ssreerama deleted the sai/mar/codeAnalysis_mssqlSampleDialog branch February 23, 2026 18:46

Conversation

ssreerama commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Changes

Uh oh!

codecov-commenter commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ssreerama commented Feb 19, 2026 •

edited

Loading

github-actions Bot commented Feb 19, 2026 •

edited

Loading

codecov-commenter commented Feb 19, 2026 •

edited

Loading