Conversation
Benjin
requested review from
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds a new REVIEW.md file in the .github/copilot/ directory to provide specific instructions for the GitHub Copilot PR agent when reviewing code. The file outlines guidelines for reviewing backend code, UIs, code health, tests, and localization, which will help ensure more consistent and relevant automated code reviews.
Changes:
- Added
.github/copilot/REVIEW.mdfile with instructions for the GitHub Copilot PR agent covering backend code, UI patterns, code health, testing practices, and localization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21193 +/- ##
=======================================
Coverage 71.85% 71.85%
=======================================
Files 281 281
Lines 89892 89892
Branches 4640 4640
=======================================
Hits 64594 64594
Misses 25298 25298 🚀 New features to boost your workflow:
|
manujoseph85
left a comment
manujoseph85
left a comment
There was a problem hiding this comment.
This is a good start. We can improve this over time.
Benjin
dismissed stale reviews from kburtram, lewis-sanchez, and manujoseph85
via
a402452
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - DO check for stubs that are constructed manually instead of loosely-defined objects of stubs | ||
| - DO check for places where stubs are created outside of a sandbox. | ||
| - DO check to make sure that the shared sinon stubs are used wherever possible, and that good candidates are added to the collection of premade stubs (found in `extensions\mssql\test\unit\utils.ts`) |
There was a problem hiding this comment.
File path uses backslashes which is Windows-specific. Consider using forward slashes for cross-platform compatibility and consistency with the rest of the repository (e.g., extensions/mssql/test/unit/utils.ts).
| - React/webview frontend localized strings go in: `extensions\mssql\src\reactviews\common\locConstants.ts` | ||
| - All other localized strings go in: `extensions\mssql\src\constants\locConstants.ts` |
There was a problem hiding this comment.
File paths use backslashes which is Windows-specific. Consider using forward slashes for cross-platform compatibility and consistency with the rest of the repository (e.g., extensions/mssql/src/reactviews/common/locConstants.ts and extensions/mssql/src/constants/locConstants.ts).
Adding GHCP PR agent instructions
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines