Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors string validation logic by using JDTUtils.toURI() for URI parsing and replacing custom null/empty checks with Apache Commons StringUtils utilities.
- Replaced manual URI parsing with
JDTUtils.toURI()inProjectCommand.getProjectDependencies() - Replaced custom
isNotEmpty()utility and manual null/empty checks withStringUtils.isBlank()andStringUtils.isNotBlank() - Removed the custom
isNotEmpty()helper method fromContextResolver
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ProjectCommand.java | Switched from manual java.net.URI constructor to JDTUtils.toURI() for URI parsing and validation |
| ContextResolver.java | Replaced all manual null/empty string checks and custom isNotEmpty() with Apache Commons StringUtils methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...xt/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/parser/ContextResolver.java
Outdated
Show resolved
Hide resolved
...xt/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/parser/ContextResolver.java
Outdated
Show resolved
Hide resolved
chagong
previously approved these changes
Nov 17, 2025
chagong
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.