Add a message explaining why we couldn't find a quote-wrapped path#13521
Merged
Add a message explaining why we couldn't find a quote-wrapped path#13521
Conversation
Contributor
Member
Author
Contributor
But it's inconsistent with the UI message? Is that intentional? |
Member
Author
I believe it might have been done that way because we show all the paths on the same line for the tooltip, but in the UI we give each error its own line. It makes the paths easier to differentiate. |
sean-mcmanus
previously approved these changes
Apr 16, 2025
sean-mcmanus
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes: #11955
The bug suggests that we shouldn't show an error for paths wrapped in quotes, but we had decided to treat these strings literally since a double quote is a valid path character on some platforms.
Instead, this message improvement should signal to users that they should not place extra quotes around paths.