Conversation
aeschli
previously approved these changes
Jan 9, 2026
… into pawang/loadSkill
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds custom chat rendering for agent skills, modifying how skill file operations are displayed in the chat UI. The changes distinguish skill files from regular files in invocation messages, providing clearer context when agent tools interact with skill files.
Key changes:
- Extended
ICustomInstructionsServiceinterface withisSkillMdFileandgetSkillInfomethods - Modified
ReadFileTool.prepareInvocationto render skill-specific invocation messages - Added
formatUriForFileWidgetsupport for custom file name metadata via optional parameters
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/platform/customInstructions/common/customInstructionsService.ts |
Added new interface methods and refactored skills location matching to return skill metadata; includes helper methods for skill directory/name extraction |
src/platform/test/common/testCustomInstructionsService.ts |
New mock service implementation for testing custom instructions functionality |
src/extension/tools/common/toolUtils.ts |
Extended formatUriForFileWidget to support optional file name metadata |
src/extension/tools/node/readFileTool.tsx |
Modified prepareInvocation to display skill-specific messages when reading skill files |
src/extension/tools/node/getErrorsTool.tsx |
Updated formatURIs call to be explicit about parameter passing |
src/extension/tools/node/findTestsFilesTool.tsx |
Updated formatURIs call to be explicit about parameter passing |
src/extension/tools/node/test/readFile.spec.tsx |
Added comprehensive tests for skill file rendering in prepareInvocation |
src/extension/tools/node/test/editFileToolUtils.spec.ts |
Refactored to use shared MockCustomInstructionsService instead of inline mock |
roblourens
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on microsoft/vscode#286839
Handles the invocation text changes
Fixes microsoft/vscode#286213