added REQUIRED to the list of cmake operators and added a regex to capture integers#4596
added REQUIRED to the list of cmake operators and added a regex to capture integers#4596DARKMOONlite wants to merge 1 commit intomicrosoft:release/1.21from
Conversation
…best. Also added in an option that looks for integer values and sets them to be a `constant.numeric.decimal.cmake` token.
|
Hi @DARKMOONlite :) Thanks for the contribution and for caring about CMake readability! 🙂 I have a couple of concerns with the current approach: REQUIRED as an operator: In CMake's grammar, REQUIRED is a command-specific keyword (e.g., for Integer/version highlighting: The regex \bv?\d+(?:.\d+)*\b is quite broad as CMake treats nearly everything as I'd suggest narrowing the scope. For example, only highlighting numbers in specific contexts where they're |
The purpose of this change
To improve readability of CMake code by distinguishing numeric values from other. and adding REQUIRED to the list of parameters that should get some syntactic icing sugar.
I recently was running into issues with a large cmake project and had troubles reading it. After realising that most of my worries came from the fact that I had a deprecated cmake vscode extension that was ruining all syntax highlighting, I decided to try and improve it by submitting what i believe would be a good change to the repo.
Note: I was able to get this working on the main branch as well but since this commit d217cac, effectively removed the advanced syntax highlighting that i was fond of in the latest update I decided to submit the pull request here where they could be combined together to make it very nice to look at. IDK if that was correct, if you want i can submit the pull request from this change
Other Notes/Information
Example:
This was just a sample
CMakeLists.txtfile, using theAndromeda Italic Borderedtheme with the following pull request EliverLara/Andromeda#40 which improves its syntax highlighting for cmake.this pull request can be effectively replicated by adding the following code to the
settings.jsonfileAs you can see.
Very Mindful. Very Demure.