Fix per-client ServiceVersion regression in http-client-java

[XiaofeiCao]

Fixes per-client ServiceVersion regression

Problem

For a package containing multiple TypeSpec clients, the emitter is supposed to generate a single shared ServiceVersion enum (named after the package/service) when all clients use the same api-versions, and only fall back to a per-client <ClientName>ServiceVersion when the clients genuinely have different api-versions.

Recently, multi-client packages started generating a separate ServiceVersion enum per client even when all clients share the same api-versions, e.g.:

• azure-search-documents: SearchServiceVersion → SearchIndexServiceVersion, SearchIndexerServiceVersion, KnowledgeBaseRetrievalServiceVersion
• azure-developer-devcenter: DevCenterServiceVersion → DevCenterServiceVersion, DevBoxesServiceVersion, DeploymentEnvironmentsServiceVersion
• azure-communication-messages, eventgrid-namespaces, etc.

Root cause

In code-model-builder.ts, the "same api-versions for all clients" check was changed in #11134 (replacing lodash.isEqual with a built-in comparison):

// before
apiVersionSameForAllClients = isEqual(sharedApiVersions, apiVersions);
// after
apiVersionSameForAllClients =
  sharedApiVersions.length === apiVersions.length &&
  sharedApiVersions.every((it, index) => it === apiVersions[index]);

apiVersions is ApiVersion[] (objects), not string[]. Each client builds its own ApiVersion instances:

const apiVersion = new ApiVersion();
apiVersion.version = version.value;
codeModelClient.apiVersions.push(apiVersion);

lodash.isEqual did a deep value comparison (equal versions → treated as equal), but === compares object references, which is always false for distinct instances. As a result apiVersionSameForAllClients became false for every multi-client package, triggering the per-client ServiceVersion branch.

Fix

Compare the api-version strings instead of the ApiVersion object references:

apiVersionSameForAllClients =
  sharedApiVersions.length === apiVersions.length &&
  sharedApiVersions.every((it, index) => it.version === apiVersions[index].version);

This restores a single shared ServiceVersion for multi-client packages whose clients use the same api-versions, while still producing per-client ServiceVersion enums when the api-versions actually differ.

Notes

• Draft: end-to-end generation/regression tests still to be run.
• Related downstream regeneration: [Automation] Generate SDK based on TypeSpec 0.45.6 Azure/azure-sdk-for-java#49842.

[github-actions]

All changed packages have been documented.

• ✅ @typespec/http-client-java

Show changes

@typespec/http-client-java - fix ✏️

Fix multi-client packages generating a separate ServiceVersion enum per client when all clients share the same api-versions. The api-version comparison now compares version strings instead of ApiVersion object references, restoring a single shared ServiceVersion for such packages.

[azure-sdk-automation]

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension