Skip to content

Ensure output directory exists before writing files in http-client-csharp emitter #10138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Ensure output directory exists before writing files in http-client-csharp emitter #10138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce07e4e
Initial plan
Copilot Mar 25, 2026
7bc9803
fix: ensure output directory exists before writing files in http-clie…
Copilot Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/http-client-csharp/emitter/src/code-model-writer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export async function writeCodeModel(
codeModel: CodeModel,
outputFolder: string,
) {
await context.program.host.mkdirp(outputFolder);
await context.program.host.writeFile(
resolvePath(outputFolder, tspOutputFileName),
prettierOutput(JSON.stringify(buildJson(context, codeModel), transformJSONProperties, 2)),
Expand Down Expand Up @@ -104,6 +105,7 @@ export async function writeConfiguration(
configurations: Configuration,
outputFolder: string,
) {
await context.program.host.mkdirp(outputFolder);
await context.program.host.writeFile(
resolvePath(outputFolder, configurationFileName),
prettierOutput(JSON.stringify(configurations, null, 2)),
Expand Down
8 changes: 8 additions & 0 deletions packages/http-client-csharp/emitter/test/Unit/emitter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ describe("$onEmit tests", () => {
hasError: () => false,
host: {
writeFile: vi.fn(),
mkdirp: vi.fn(),
rm: vi.fn(),
},
tracer: {
Expand All @@ -84,6 +85,13 @@ describe("$onEmit tests", () => {
$onEmit = (await import("../../src/emitter.js")).$onEmit;
});

it("should ensure output folder exists before writing files", async () => {
const context: EmitContext<CSharpEmitterOptions> = createEmitterContext(program);
await $onEmit(context);
// writeCodeModel and writeConfiguration each call mkdirp with the output folder
expect(program.host.mkdirp).toHaveBeenCalledWith(context.emitterOutputDir);
});

it("should apply the update-code-model callback just once", async () => {
const context: EmitContext<CSharpEmitterOptions> = createEmitterContext(program);
const updateCallback = vi.fn().mockImplementation((model: CodeModel) => {
Expand Down