fix: allow destructured require under module preserve + verbatimModuleSyntax

[Sankalp Thakur (sankalpsthakur)]

Summary

Fixes microsoft/TypeScript#63696.

Refile of microsoft/TypeScript#63732 (closed by Jake Bailey (@jakebailey) — JS TypeScript repo is closed for development; fix belongs here per CONTRIBUTING.md and pinned #62963).

Under --module preserve with --verbatimModuleSyntax, CommonJS files (e.g. .cjs) correctly allow bare require assignments:

const whole = require("./mod"); // ok

but incorrectly reported TS1293 on destructured require:

const { x } = require("./mod"); // was false-positive TS1293

Cause

In checkAliasSymbol, the preserve-mode CommonJS check excludes ImportEqualsDeclaration and VariableDeclaration (the latter covers const x = require(...)), but object-destructuring aliases are modeled as BindingElement nodes (const { x } = require(...)) and fell through to the ESM-syntax error.

Fix

Also exclude KindBindingElement from that check so CJS require destructuring is treated like whole-module require. Real ESM import/export syntax in unambiguously CommonJS files still errors.

Test

New local compiler test modulePreserveDestructuredRequire.ts:

• const { x } = require("./mod") — no error
• const { y: renamed } = require("./mod") — no error
• const whole = require("./mod") — no error
• import { x as x2 } from "./mod" in .cjs — still TS1293

go test ./internal/testrunner/ -count=1 -run 'TestLocal/modulePreserveDestructuredRequire'

AI disclosure

This change was developed with assistance from an LLM (coding agent). I reviewed the root cause, the patch, and the test baselines before submitting. This is a targeted refile of a specific closed PR (not bulk/queue-driven issue hunting).

[Copilot]

Pull request overview

Fixes false-positive TS1293 diagnostics for destructured CommonJS require calls under module-preserve mode.

Changes:

• Exempts BindingElement aliases from the ESM syntax diagnostic.
• Adds compiler coverage and expected error/type/symbol baselines.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/checker/checker.go	Allows destructured CommonJS aliases.
testdata/tests/cases/compiler/modulePreserveDestructuredRequire.ts	Adds regression coverage.
testdata/baselines/reference/compiler/modulePreserveDestructuredRequire.errors.txt	Verifies only genuine ESM syntax errors.
testdata/baselines/reference/compiler/modulePreserveDestructuredRequire.types	Records inferred types.
testdata/baselines/reference/compiler/modulePreserveDestructuredRequire.symbols	Records resolved symbols.