Skip to content

[api] Add .getNonPrimitiveType() getter#4533

Open
mrazauskas wants to merge 1 commit into
microsoft:mainfrom
mrazauskas:add-getNonPrimitiveType
Open

[api] Add .getNonPrimitiveType() getter#4533
mrazauskas wants to merge 1 commit into
microsoft:mainfrom
mrazauskas:add-getNonPrimitiveType

Conversation

@mrazauskas

Copy link
Copy Markdown

Close #2850

This PR adds the missing .getNonPrimitiveType() getter.

Signed-off-by: mrazauskas <tom@mrazauskas.de>
Copilot AI review requested due to automatic review settings July 4, 2026 06:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing getNonPrimitiveType intrinsic type getter to the native TypeScript-Go API surface, aligning the checker intrinsic getters with upstream/Strada expectations (issue #2850).

Changes:

  • Exposes Checker.GetNonPrimitiveType() from the Go checker (c.nonPrimitiveType).
  • Wires a new API method (getNonPrimitiveType) through the server protocol + request handler.
  • Adds sync/async native-preview client methods and coverage in both sync/async API test suites.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/checker/exports.go Adds exported Go checker getter GetNonPrimitiveType() returning c.nonPrimitiveType.
internal/api/session.go Routes getNonPrimitiveType requests to the intrinsic-type handler using the new checker getter.
internal/api/proto.go Adds MethodGetNonPrimitiveType constant and registers its params unmarshaller.
_packages/native-preview/src/api/sync/api.ts Adds checker.getNonPrimitiveType() to the sync client wrapper.
_packages/native-preview/src/api/async/api.ts Adds checker.getNonPrimitiveType() to the async client wrapper.
_packages/native-preview/test/sync/api.test.ts Adds a test asserting returned type includes TypeFlags.NonPrimitive.
_packages/native-preview/test/async/api.test.ts Adds the async equivalent test for TypeFlags.NonPrimitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .getNonPrimitiveType() getter

2 participants