[api] Add .getNonPrimitiveType() getter#4533
Open
mrazauskas wants to merge 1 commit into
Open
Conversation
Signed-off-by: mrazauskas <tom@mrazauskas.de>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing getNonPrimitiveType intrinsic type getter to the native TypeScript-Go API surface, aligning the checker intrinsic getters with upstream/Strada expectations (issue #2850).
Changes:
- Exposes
Checker.GetNonPrimitiveType()from the Go checker (c.nonPrimitiveType). - Wires a new API method (
getNonPrimitiveType) through the server protocol + request handler. - Adds sync/async native-preview client methods and coverage in both sync/async API test suites.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/checker/exports.go | Adds exported Go checker getter GetNonPrimitiveType() returning c.nonPrimitiveType. |
| internal/api/session.go | Routes getNonPrimitiveType requests to the intrinsic-type handler using the new checker getter. |
| internal/api/proto.go | Adds MethodGetNonPrimitiveType constant and registers its params unmarshaller. |
| _packages/native-preview/src/api/sync/api.ts | Adds checker.getNonPrimitiveType() to the sync client wrapper. |
| _packages/native-preview/src/api/async/api.ts | Adds checker.getNonPrimitiveType() to the async client wrapper. |
| _packages/native-preview/test/sync/api.test.ts | Adds a test asserting returned type includes TypeFlags.NonPrimitive. |
| _packages/native-preview/test/async/api.test.ts | Adds the async equivalent test for TypeFlags.NonPrimitive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2850
This PR adds the missing
.getNonPrimitiveType()getter.