New extension layout#4489
Open
jakebailey wants to merge 42 commits into
Open
Conversation
jakebailey
commented
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures the VS Code extension layout by splitting the current extension into a new “main” extension (vscode-typescript) and a separate nightly extension (native-preview), while migrating configuration to js/ts.* settings (with legacy typescript.native-preview.* still supported via deprecation/back-compat).
Changes:
- Add a new
_extension-nightlyworkspace/package and update workspace wiring (package.json,package-lock.json). - Update build/packaging to produce VSIX artifacts for both the main and nightly extensions (
Herebyfile.mjs). - Migrate configuration and UX strings to the new
js/ts.*settings and “TypeScript 7 Native Preview” naming across extension + LSP preference handling.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds _extension-nightly to the monorepo workspaces. |
| package-lock.json | Updates workspace package names/links for vscode-typescript and native-preview (nightly). |
| internal/project/customconfigfilename_test.go | Updates preference parsing test to use js/ts.customConfigFileName directly. |
| internal/ls/lsutil/userpreferences.go | Changes CustomConfigFileName config mapping to match the new js/ts layout. |
| Herebyfile.mjs | Extends VSIX packaging to build both “typescript-vscode” and “typescript-nightly” artifacts. |
| _extension/src/util.ts | Adds new TSDK candidate resolution and optional nightly exe selection plumbing; adds shared naming constants. |
| _extension/src/statusBar.ts | Updates UI strings to “TypeScript 7 Native Preview”. |
| _extension/src/session.ts | Migrates config reads/updates to js/ts.* and adjusts UI text accordingly. |
| _extension/src/projectStatus.ts | Updates project status UI name. |
| _extension/src/extension.ts | Reacts to new TSDK-related settings and updates onboarding/enablement behavior. |
| _extension/src/configurationMiddleware.ts | Merges js/ts + legacy typescript.native-preview settings for server config back-compat. |
| _extension/src/commands.ts | Updates documentation comment to the new extension name. |
| _extension/src/client.ts | Updates LanguageClient naming/branding and config reads. |
| _extension/README.md | Updates README for new extension name and js/ts.tsdk.path configuration. |
| _extension/package.nls.json | Updates extension description and adds deprecation messages for legacy settings keys. |
| _extension/package.json | Renames the extension package to vscode-typescript, contributes js/ts.* settings, and deprecates old ones. |
| _extension/l10n/bundle.l10n.json | Updates localization keys/strings for new naming and one new error string. |
| _extension-nightly/src/extension.js | Adds a small “nightly” extension that auto-installs the replacement extension when missing. |
| _extension-nightly/README.md | Documents the nightly extension’s purpose and relationship to the main extension. |
| _extension-nightly/package.nls.json | Adds marketplace description string. |
| _extension-nightly/package.json | Defines the nightly extension package metadata and activation. |
| _extension-nightly/LICENSE | Adds Apache 2.0 license text for the new nightly extension package. |
# Conflicts: # testdata/baselines/reference/fourslash/state/codeLensAcrossProjects.baseline
# Conflicts: # _extension/src/configurationMiddleware.ts
DanielRosenwasser
requested changes
Jul 2, 2026
DanielRosenwasser
requested changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3722
For #3727
This restructures our extensions into:
vscode-typescript, displayed as TypeScript 7. This is the client extension that goes into VS Code. It carries bundled TS/tsgo bits for now, and requires VS Code 1.126+ so the built-in extension recognizes both the new and old extension IDs.native-previewbecomes the TypeScript 7 Nightly extension. It is now just the nightly version box; if installed,vscode-typescriptprefers its contents over the bundled contents, matching how the built-in TypeScript extension uses TypeScript Nightly.native-previewis installed by itself, it installsvscode-typescriptso existing users still end up with the real client extension.vscode-typescriptself-manages the existinguseTsgohandoff so current VS Code can switch between Strada and Corsa. It supports the normal version selector flow, but uses private command IDs for the Corsa handlers so the two extensions do not register the same command IDs.vscode-typescriptnow respectsjs/ts.*settings instead oftypescript.native-preview.*, with back compat and deprecation messages for now.