restore JSDoc member name check for private identifier references

internal/fourslash/tests/manual/findAllReferencesJSDocPrivateIdentifier_test.go

@@ -0,0 +1,26 @@
+package fourslash_test
+
+import (
+	"testing"
+
+	"github.com/microsoft/typescript-go/internal/fourslash"
+	"github.com/microsoft/typescript-go/internal/testutil"
+)
+
+func TestFindAllReferencesJSDocPrivateIdentifier(t *testing.T) {
+	t.Parallel()
+	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
+	const content = `
+class C {
+    /*1*/#field;
+    /**
+     * @see C./*2*/#field
+     */
+    method() {}
+}
+`
+	f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
+	defer done()
+
+	f.VerifyBaselineFindAllReferences(t, "1", "2")
+}

internal/ls/findallreferences.go

@@ -348,10 +348,9 @@ func getRangeOfNode(node *ast.Node, sourceFile *ast.SourceFile, endNode *ast.Nod
 func isValidReferencePosition(node *ast.Node, searchSymbolName string) bool {
 	switch node.Kind {
 	case ast.KindPrivateIdentifier:
-		// !!!
-		// if (isJSDocMemberName(node.Parent)) {
-		// 	return true;
-		// }
+		if isJSDocMemberName(node.Parent) {
+			return true
+		}
 		return len(node.Text()) == len(searchSymbolName)
 	case ast.KindIdentifier:
 		return len(node.Text()) == len(searchSymbolName)
@@ -2652,3 +2651,16 @@ func (state *refState) explicitlyInheritsFrom(symbol *ast.Symbol, parent *ast.Sy
 	state.inheritsFromCache[key] = inherits
 	return inherits
 }
+
+func isJSDocMemberName(node *ast.Node) bool {
+	if node == nil {
+		return false
+	}
+	if node.Kind == ast.KindIdentifier || node.Kind == ast.KindPrivateIdentifier {
+		return true
+	}
+	if node.Kind == ast.KindPropertyAccessExpression {
+		return isJSDocMemberName(node.AsPropertyAccessExpression().Name())
+	}
+	return false
+}

testdata/baselines/reference/submodule/fourslash/findAllReferences/findAllReferencesJSDocPrivateIdentifier.baseline.jsonc

@@ -0,0 +1,23 @@
+// === findAllReferences ===
+// === /findAllReferencesJSDocPrivateIdentifier.ts ===
+// 
+// class C {
+//     /*FIND ALL REFS*/[|#field|];
+//     /**
+//      * @see C.#field
+//      */
+// --- (line: 7) skipped ---
+
+
+
+// === findAllReferences ===
+// === /findAllReferencesJSDocPrivateIdentifier.ts ===
+// 
+// class C {
+//     #field;
+//     /**
+//      * @see C./*FIND ALL REFS*/#field
+//      */
+//     method() {}
+// }
+// 

testdata/baselines/reference/submoduleAccepted/fourslash/findAllReferences/findAllReferencesJSDocPrivateIdentifier.baseline.jsonc.diff

@@ -0,0 +1,26 @@
+--- old.findAllReferencesJSDocPrivateIdentifier.baseline.jsonc
++++ new.findAllReferencesJSDocPrivateIdentifier.baseline.jsonc
+@@= skipped --1, +0 lines =@@
++// === findAllReferences ===
++// === /findAllReferencesJSDocPrivateIdentifier.ts ===
++// 
++// class C {
++//     /*FIND ALL REFS*/[|#field|];
++//     /**
++//      * @see C.#field
++//      */
++// --- (line: 7) skipped ---
++
++
++
++// === findAllReferences ===
++// === /findAllReferencesJSDocPrivateIdentifier.ts ===
++// 
++// class C {
++//     #field;
++//     /**
++//      * @see C./*FIND ALL REFS*/#field
++//      */
++//     method() {}
++// }
++// 

testdata/submoduleAccepted.txt

@@ -1412,3 +1412,4 @@ conformance/callbackTagVariadicType.js.diff
 # definiteAssignment shorthand in object literal loses optional modifier
 ## https://github.com/microsoft/typescript-go/issues/3563
 conformance/definiteAssignmentAssertionsWithObjectShortHand.js.diff
+fourslash/findAllReferences/findAllReferencesJSDocPrivateIdentifier.baseline.jsonc.diff