fix(3810): handle deprecated tags in completions#3828
Merged
Conversation
Member
|
Is there some non-converted test that this should fix? |
gabritto
requested changes
May 13, 2026
| } | ||
|
|
||
| var ( | ||
| completionIgnoreOpts = ignorePaths(".Kind", ".SortText", ".FilterText", ".Data", ".AdditionalTextEdits") |
Member
There was a problem hiding this comment.
Could we not ignore .Tags and instead just update the tests?
jakebailey
approved these changes
May 14, 2026
gabritto
reviewed
May 14, 2026
| return fmt.Sprintf("%s:\n%s", "Kind mismatch", err) | ||
| } | ||
| } | ||
| if expected.Tags != nil { |
Member
There was a problem hiding this comment.
Do we still need this if we're no longer ignoring .Tags in the completion options above?
gabritto
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3810