Skip to content

Comments

Unskip 14 passing formatting fourslash tests#2863

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/debug-unstable-tests
Closed

Unskip 14 passing formatting fourslash tests#2863
Copilot wants to merge 2 commits intomainfrom
copilot/debug-unstable-tests

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

These 14 formatting tests were skipped but now pass consistently after recent formatter fixes in #2793 and #2852.

Root cause

The tests exercised three bugs in internal/format/span.go, all now fixed:

Potential race (not confirmed)

warmAutoImportCache runs in a background goroutine and calls getSnapshotflushChanges, which drains pendingFileChanges. The dispatch loop does the same for formatting requests. If the background task runs between a didChange being queued and the formatting request's getSnapshot, it could drain the change first. The snapshot ends up correct either way, but goroutine scheduling determines who flushes. Unable to reproduce flakiness despite 200+ runs with race detector, stress conditions, and full suite repetition.

Changes

  • Removed 14 test names from internal/fourslash/_scripts/failingTests.txt

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix unstable test cases for consistent results Unskip 14 passing formatting fourslash tests Feb 20, 2026
Copilot AI requested a review from jakebailey February 20, 2026 23:21
@jakebailey jakebailey closed this Feb 24, 2026
@jakebailey jakebailey deleted the copilot/debug-unstable-tests branch February 24, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants