Update JsxOpeningElement type#2469
Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom Jan 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the type hierarchy for JsxOpeningElement to reflect that it is a structural component of a JSX element rather than a standalone expression.
Changes:
- Updated
JsxOpeningElementinterface to extendNodeinstead ofExpression
DanielRosenwasser
approved these changes
Jan 26, 2026
andrewbranch
approved these changes
Jan 27, 2026
Member
|
It's |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given it can only be the child of a JsxElement, I think it's a mistake to mark it as an Expression