Port --isolatedDeclarations related node builder logic, with baseline updates #2459
+17,176
−28,102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than expression ones so widening is handled correctly
…cker data is ready, reducing literal expression diffs
…on/better comparitor to fallback to standard serialization less aggressively
weswigham
force-pushed
the
id-with-baselines
branch
from
e1642a6 to
05140dd
Compare
jakebailey
reviewed
Jan 9, 2026
| f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content) | ||
| defer done() | ||
| f.GoToMarker(t, "1") | ||
| f.VerifySignatureHelp(t, fourslash.VerifySignatureHelpOptions{Text: "foo(name: 'order'): string", OverloadsCount: 4}) |
Member
There was a problem hiding this comment.
You could actually "promote" these to manual tests if you wanted; the original tests were dependent on old bad behavior, it seems.
jakebailey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1693 but with the baseline update change floated on top of it, so the actual implementation remains reviewable on github.