Fix decorated class methods with Symbol names to emit valid code#2447
Closed
Fix decorated class methods with Symbol names to emit valid code#2447
Conversation
Add visitPropertyNameOfClassElement function to handle computed property names for decorated class elements. When a class element has decorators and a computed property name that is not a simple inlineable expression, the function: 1. Creates a generated name for the computed property 2. Hoists a variable declaration for that name 3. Updates the computed property to assign the expression to that name This ensures the __decorate call can reference the same value that was used in the class definition. Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tsgo code emission for Symbol method names
Fix decorated class methods with Symbol names to emit valid code
Jan 7, 2026
Member
|
I independently discovered this in #2956. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsgoemitted invalid JavaScript for decorated class methods with computed property names like[Symbol()]. The generated__decoratecall referenced an undefined variable, causingReferenceError: _a is not definedat runtime.Before (broken):
After (fixed):
Changes
visitPropertyNameOfClassElementinlegacydecorators.goto detect decorated class elements with non-simple computed property namesAddVariableDeclaration, and update the computed property to assign the expression to that namevisitMethodDeclaration,visitPropertyDeclaration,visitGetAccessorDeclaration, andvisitSetAccessorDeclarationto use this new functionlegacyDecoratorSymbolMethodName.tscovering the reported scenarioOriginal prompt
tsgoemits invalid code for decorated class methods withSymbolnames #2446✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.