Skip to content

Also ignore copilot-curate.instructions.md from markdownlint#8852

Merged
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/lint-curate-instructions
Jun 5, 2026
Merged

Also ignore copilot-curate.instructions.md from markdownlint#8852
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/lint-curate-instructions

Conversation

@Evangelink
Copy link
Copy Markdown
Member

Follow-up to #8851. This second file under .github/instructions/ is also auto-generated by gh copilot-curate and triggers 96 markdownlint errors (MD041/MD049/MD038) that would be wiped out on the next regeneration. Adding it to the ignores keeps the lint job green without fighting the generator.

This will also unblock lint CI on PRs #8580, #8586, #8819, #8820, #8823.

Follow-up to #8851: `.github/instructions/copilot-curate.instructions.md`
is the second file produced by `gh copilot-curate` (alongside `AGENTS.md`).
Its front-matter and dense plain-text skill catalog trigger 96 lint errors
(MD041 first-line-h1, MD049 emphasis-style, MD038 spaces-in-code) that would
all be wiped out on the next regeneration. Adding it to the markdownlint
ignores keeps the lint job green without fighting the generator.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 5, 2026 07:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR keeps the repository’s markdownlint job green by excluding an additional gh copilot-curate auto-generated instructions file from markdownlint scanning, avoiding errors that would be reintroduced on the next regeneration.

Changes:

  • Add .github/instructions/copilot-curate.instructions.md to markdownlint-cli2 ignore patterns.
  • Adjust the ignore list formatting to accommodate the new entry (adds a comma after AGENTS.md).
Show a summary per file
File Description
.markdownlint-cli2.jsonc Adds the auto-generated Copilot-curate instructions file to ignores to prevent persistent markdownlint failures.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Copy link
Copy Markdown
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/21 dimensions clean — no findings.

This is a config-only PR (non-code scope). All runtime, API surface, threading, performance, test quality, and IPC dimensions are N/A. The single-line change to .markdownlint-cli2.jsonc is syntactically correct JSONC, the new entry is consistent with the AGENTS.md entry directly above it (same comment, same rationale), and the approach of listing auto-generated files explicitly rather than glob-ignoring the whole .github/instructions/ directory is the right call — it keeps legitimately maintained files under lint coverage.

Generated by Expert Code Review (on open) for issue #8852 · sonnet46 1.6M

@Evangelink Evangelink enabled auto-merge (squash) June 5, 2026 08:29
@Evangelink Evangelink merged commit 4c10845 into main Jun 5, 2026
29 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/lint-curate-instructions branch June 5, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants