Merged
Conversation
nohwnd
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExecuteRequestAsync(ExecuteRequestContext)is ONLY ever called by core MTP. Core MTP never passes VSTestDiscoverTestExecutionRequest or VSTestRunTestExecutionRequest.The flow currently goes like:
ExecuteRequestAsync(ExecuteRequestContext), where the request is eitherDiscoverTestExecutionRequestorRunTestExecutionRequestExecuteRequestAsync(TestExecutionRequest,IMessageBus,CancellationToken).ExecuteRequestAsync(TestExecutionRequest,IMessageBus,CancellationToken)is abstract and is overridden bySynchronizedSingleSessionVSTestBridgedTestFramework. The implementation of the override handlesDiscoverTestExecutionRequestandRunTestExecutionRequestby transforming them toVSTestDiscoverTestExecutionRequestandVSTestRunTestExecutionRequestand then calls eitherSynchronizedDiscoverTestsAsyncorSynchronizedRunTestsAsyncSynchronizedDiscoverTestsAsyncandSynchronizedRunTestsAsyncare abstract and are implementable by frameworks outside the bridge (e.g, MSTest, NUnit, Expecto). Those methods take the concreteVSTestDiscoverTestExecutionRequestandVSTestRunTestExecutionRequestas parameters.Additional cleanup that can be done but is breaking change:
VSTestDiscoverTestExecutionRequestandVSTestRunTestExecutionRequestdon't need to inheritDiscoverTestExecutionRequestandRunTestExecutionRequest. In fact, I tend to think that MTP should have madeDiscoverTestExecutionRequestandRunTestExecutionRequestsealed.DiscoverTestsAsyncandRunTestsAsyncimplemented inSynchronizedSingleSessionVSTestBridgedTestFrameworkare dead and are never called.