Refactor Assert.StringDifference into focused files#10182
Merged
Evangelink merged 2 commits intoJul 24, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ab5160cf-e6b4-4ba6-b58e-e3b8ba116305
Contributor
There was a problem hiding this comment.
Pull request overview
Splits string-difference diagnostics into focused partial-class files without changing behavior or public APIs.
Changes:
- Separates tokenization, rendering, and formatting logic.
- Keeps each resulting file below 300 lines.
- Preserves existing implementation and tests.
Show a summary per file
| File | Description |
|---|---|
Assert.StringDifference.cs |
Retains entry points and core diagnostic types. |
Assert.StringDifference.Tokenizer.cs |
Contains Unicode tokenization logic and types. |
Assert.StringDifference.Rendering.cs |
Contains preview and mismatch rendering. |
Assert.StringDifference.Formatting.cs |
Contains escaping and code-point formatting. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Medium
Evangelink
enabled auto-merge (squash)
July 23, 2026 19:55
0101
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10181
Testing
.\build.cmd -test -bl