Disable focus mode by default in quake mode#19396
Closed
b-hayes wants to merge 1 commit intomicrosoft:mainfrom
Closed
Disable focus mode by default in quake mode#19396b-hayes wants to merge 1 commit intomicrosoft:mainfrom
b-hayes wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quake mode currently forces focus mode to be enabled, which hides the tab bar. This PR removes that automatic behavior, allowing users to manually toggle focus mode on/off as needed.
Changes
Motivation
See issue: #11085
Its to hard to use when in quake mode there is no benefit to hide the tabs by default.
Test plan
I am not setup to build and test.
If anyone can help test this would be awesome.
Related issue: 11085