Skip to content

Skip unused Bazel install in benchmark Docker image #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −0
Draft

Skip unused Bazel install in benchmark Docker image #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c217688
Initial plan
Copilot Aug 13, 2026
86a33fb
Apply remaining changes
Copilot Aug 13, 2026
2677763
Fix benchmark Docker build: skip broken Bazel install; stop tracking …
Copilot Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@

# rust target
/target
/PLAN.md
11 changes: 11 additions & 0 deletions benchmark/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ RUN git clone https://github.com/daanx/mimalloc-bench &&\
git reset --hard a4ce904286365c7adfba54f0eea3a2df3fc95bd1

WORKDIR /mimalloc-bench

# Skip the Bazel install: it is only needed to build Google's tcmalloc (tcg),
# which this Dockerfile does not build or benchmark, and its apt repository
# key (https://bazel.build/bazel-release.pub.gpg) is no longer served,
# breaking the "packages" phase below.
RUN sed -i '/^[[:space:]]*aptinstallbazel[[:space:]]*$/d' build-bench-env.sh && \
if grep -qE '^[[:space:]]*aptinstallbazel[[:space:]]*$' build-bench-env.sh; then \
echo "error: aptinstallbazel call still present in build-bench-env.sh" >&2; \
exit 1; \
fi

# Install dependencies
RUN ./build-bench-env.sh packages

Expand Down