Skip to content

removed duplicate code causing bugs #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paullizer merged 1 commit into from
Feb 9, 2026
Merged

removed duplicate code causing bugs #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion application/single_app/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
EXECUTOR_TYPE = 'thread'
EXECUTOR_MAX_WORKERS = 30
SESSION_TYPE = 'filesystem'
VERSION = "0.237.009"
VERSION = "0.237.010"

SECRET_KEY = os.getenv('SECRET_KEY', 'dev-secret-key-change-in-production')

Expand Down
62 changes: 24 additions & 38 deletions application/single_app/static/js/group/manage_group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,39 +92,6 @@ $(document).ready(function () {
rejectRequest(requestId);
});

// Add event delegation for select user button in search results
$(document).on("click", ".select-user-btn", function () {
const id = $(this).data("user-id");
const name = $(this).data("user-name");
const email = $(this).data("user-email");
selectUserForAdd(id, name, email);
});

// Add event delegation for remove member button
$(document).on("click", ".remove-member-btn", function () {
const userId = $(this).data("user-id");
removeMember(userId);
});

// Add event delegation for change role button
$(document).on("click", ".change-role-btn", function () {
const userId = $(this).data("user-id");
const currentRole = $(this).data("user-role");
openChangeRoleModal(userId, currentRole);
$("#changeRoleModal").modal("show");
});

// Add event delegation for approve/reject request buttons
$(document).on("click", ".approve-request-btn", function () {
const requestId = $(this).data("request-id");
approveRequest(requestId);
});

$(document).on("click", ".reject-request-btn", function () {
const requestId = $(this).data("request-id");
rejectRequest(requestId);
});

// CSV Bulk Upload Events
$("#addBulkMemberBtn").on("click", function () {
$("#csvBulkUploadModal").modal("show");
Expand Down Expand Up @@ -504,11 +471,21 @@ function setRole(userId, newRole) {
data: JSON.stringify({ role: newRole }),
success: function () {
$("#changeRoleModal").modal("hide");
showToast("success", "Role updated successfully");
loadMembers();
},
error: function (err) {
console.error(err);
alert("Failed to update role.");
console.error("Error updating role:", err);
let errorMsg = "Failed to update role.";
if (err.status === 404) {
errorMsg = "Member not found. They may have been removed.";
loadMembers(); // Refresh the member list
} else if (err.status === 403) {
errorMsg = "You don't have permission to change this member's role.";
} else if (err.responseJSON && err.responseJSON.message) {
errorMsg = err.responseJSON.message;
}
showToast("error", errorMsg);
},
});
}
Expand All @@ -519,11 +496,21 @@ function removeMember(userId) {
url: `/api/groups/${groupId}/members/${userId}`,
method: "DELETE",
success: function () {
showToast("success", "Member removed successfully");
loadMembers();
},
error: function (err) {
console.error(err);
alert("Failed to remove member.");
console.error("Error removing member:", err);
let errorMsg = "Failed to remove member.";
if (err.status === 404) {
errorMsg = "Member not found. They may have already been removed.";
loadMembers(); // Refresh the member list
} else if (err.status === 403) {
errorMsg = "You don't have permission to remove this member.";
} else if (err.responseJSON && err.responseJSON.message) {
errorMsg = err.responseJSON.message;
}
showToast("error", errorMsg);
},
});
}
Expand Down Expand Up @@ -631,7 +618,6 @@ function searchUsers() {
});
}

// Render user-search results in add-member modal
// Render user-search results in add-member modal
function renderUserSearchResults(users) {
let html = "";
Expand Down
14 changes: 14 additions & 0 deletions docs/explanation/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@

# Feature Release

### **(v0.237.010)**

#### Bug Fixes

* **Manage Group Page Duplicate Code and Error Handling Fix**
* Fixed multiple code quality and user experience issues in the Manage Group page JavaScript.
* **Duplicate Event Handlers**: Removed duplicate event handler registrations (lines 96-127) for `.select-user-btn`, `.remove-member-btn`, `.change-role-btn`, `.approve-request-btn`, and `.reject-request-btn` that were causing multiple event firings.
* **Duplicate HTML in Actions Column**: Fixed member action buttons rendering duplicate attributes as visible text instead of functional buttons, causing raw HTML/CSS class names to display in the Actions column.
* **Duplicate Pending Request Buttons**: Removed duplicate Approve and Reject buttons in pending requests table that were appearing twice per request.
* **Enhanced Error Handling**: Improved `setRole()` and `removeMember()` functions with specific error messages for 404 (member not found) and 403 (permission denied) errors, automatic member list refresh on 404, and user-friendly toast notifications instead of generic alerts.
* **Removed Duplicate Comment**: Cleaned up duplicate "Render user-search results" comment.
* **Impact**: Member management buttons now render and function correctly, provide better error feedback, and auto-recover from stale member data.
* (Ref: `manage_group.js`, event handler deduplication, error handling improvements, toast notifications)

### **(v0.237.009)**

#### New Features
Expand Down