fix(Plugins.Web): Tavily max_results must not subtract Skip - #14143
Open
Diwakar Ray Yadav (Diwak4r) wants to merge 3 commits into
Open
fix(Plugins.Web): Tavily max_results must not subtract Skip#14143Diwakar Ray Yadav (Diwak4r) wants to merge 3 commits into
Diwakar Ray Yadav (Diwak4r) wants to merge 3 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Diwakar Ray Yadav (Diwak4r)
force-pushed
the
fix/latent-defect
branch
from
July 15, 2026 06:26
1e10b5c to
e5f6851
Compare
Tavily has no offset parameter, so max_results is its page size. Subtracting Skip under-fetched results when paging (Top=5, Skip=2 sent max_results=3), and Skip >= Top sent max_results <= 0. Send top directly, matching Bing's count/offset handling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diwakar Ray Yadav (Diwak4r)
force-pushed
the
fix/latent-defect
branch
from
July 31, 2026 19:22
e5f6851 to
5fd39fb
Compare
Author
|
Friendly bump — this PR has been open for ~2.5 weeks with no activity since the CLA check passed. Just rebased onto current main and force-pushed, so it's up to date again. One-line change: stop subtracting skip from max_results in TavilyTextSearch, since paging and result count are orthogonal. A unit test is included. Happy to adjust if there are review concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TavilyTextSearchsetmax_results = top - skip. Tavily has no offset parameter —max_resultsis its page size — so subtractingskipunder-fetched results when paging (Top=5, Skip=2sentmax_results=3), andSkip >= Topsentmax_results <= 0.Impact
A caller paginating with
Skip > 0gets too few (or zero) results. SiblingBingTextSearchcorrectly usescount={top}&offset={skip}; Tavily must sendtopdirectly.Fix
int? maxResults = top;Test
Added
SkipIsNotSubtractedFromMaxResultsAsynctoTavilyTextSearchTests.cs. Asserts the request body contains"max_results":5forTop=5, Skip=2. FAILS before the fix (max_results:3), PASSES after; full Tavily suite = 31 passed.🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com