refactor(rush-resolver-cache-plugin): extract repeated specifier strings into variables in tests#5802
Draft
Copilot wants to merge 3 commits into
Draft
refactor(rush-resolver-cache-plugin): extract repeated specifier strings into variables in tests#5802Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Copilot created this pull request from a session on behalf of
bmiddha
May 11, 2026 07:59
View session
Copilot
AI
changed the title
Fix file: dependency context resolution mismatch in rush-resolver-cache-plugin (pnpm v9/v10)
refactor(rush-resolver-cache-plugin): extract repeated specifier strings into variables in tests
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor test hygiene: inline specifier string literals that appear more than once (within a test or across sibling tests) are extracted to a named
const specifiervariable, matching the pattern already used in the newer edge-case tests.Tests updated in
resolveDependencyKeydescribe block:resolves link: specifier for project/non-project context'link:../bar'resolves file: specifier'file:../../../rigs/local-node-rig'resolves specifier found in packageKeys (v6)'/autoprefixer@9.8.8'(was duplicated inSetctor and function call)resolves specifier found in packageKeys (v9)'autoprefixer@9.8.8'(same)builds dependency key for plain version specifiers (v8/v9)'9.8.8'