Add RUSH_QUIET_MODE environment variable equivalent to --quiet#5700
Add RUSH_QUIET_MODE environment variable equivalent to --quiet#5700dmichon-msft merged 6 commits intomainfrom
RUSH_QUIET_MODE environment variable equivalent to --quiet#5700Conversation
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
dmichon-msft
requested review from
apostolisms,
bmiddha,
iclanton,
jxanthony and
octogonz
as code owners
|
@copilot address the build breaks. Minimally will need to rerun the build and commit the updated rush-lib.md file. |
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Fixed in 3910a1c — |
|
@copilot you need to rebase onto latest main and then redo the build and commit the updated rush-lib.api.md |
…ration order Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Fixed in 3e8bca2 — the previous edit placed |
dmichon-msft
changed the title
RUSH_QUIET_MODE environment variable equivalent to --quiet
| } | ||
| } | ||
|
|
||
| const quietModeValue: string | undefined = |
There was a problem hiding this comment.
Leave a comment about why this is checked outside of EnvironmentConfiguration.
| } | ||
| } | ||
|
|
||
| const quietModeValue: string | undefined = |
There was a problem hiding this comment.
Leave a comment about why this is checked outside of EnvironmentConfiguration.
| let commandFound: boolean = false; | ||
| let logger: ILogger = { info: console.log, error: console.error }; | ||
|
|
||
| const quietModeEnvValue: string | undefined = process.env[RUSH_QUIET_MODE]; |
There was a problem hiding this comment.
Leave a comment about why this is checked outside of EnvironmentConfiguration.
| const RUSH_PREVIEW_VERSION: string = 'RUSH_PREVIEW_VERSION'; | ||
| const RUSH_QUIET_MODE: string = 'RUSH_QUIET_MODE'; |
There was a problem hiding this comment.
| const RUSH_PREVIEW_VERSION: string = 'RUSH_PREVIEW_VERSION'; | |
| const RUSH_QUIET_MODE: string = 'RUSH_QUIET_MODE'; | |
| const RUSH_PREVIEW_VERSION_ENV_VAR_NAME: string = 'RUSH_PREVIEW_VERSION'; | |
| const RUSH_QUIET_MODE_ENV_VAR_NAME: string = 'RUSH_QUIET_MODE'; |
Also can we get the type from EnvironmentConfiguration to ensure that the value is correct?
|
|
||
| case EnvironmentVariableNames.RUSH_QUIET_MODE: { | ||
| // Accept both "true"/"false" string values and the standard "1"/"0" values | ||
| if (value === 'true' || value === 'false') { |
There was a problem hiding this comment.
Why are we also accepting true/false?
install-run-rush.ts: replace two separateloggerassignments with a singlequietboolean, set by eitherRUSH_QUIET_MODEenv var or-q/--quietarg, then assign the logger onceEnvironmentConfiguration.reset(): remove extra blank line, add missing resets for_gitBinaryPathand_tarBinaryPathrush-lib.api.md: addquietModegetter toEnvironmentConfigurationclass (alphabetical order) andRUSH_QUIET_MODEtoEnvironmentVariableNames(at end, matching source declaration order)💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.