-
Notifications
You must be signed in to change notification settings - Fork 679
[rush] (BREAKING CHANGE) Overhaul watch-mode to facilitate orchestration #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmichon-msft
wants to merge
22
commits into
microsoft:main
Choose a base branch
from
dmichon-msft:watch-rework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,493
−4,821
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2dbb1d2
[rush] Make phased execution stateful
dmichon-msft 621da60
rush update
dmichon-msft 8f808c6
Fix cache write logic
dmichon-msft 1973934
Allow reading terminal destinations
dmichon-msft dea0bf1
Fix superfluous iswatch check
dmichon-msft 520d0b1
Reconciliation of tests
dmichon-msft 1799511
Reconciliation
dmichon-msft 22758a3
lastExecutionResults -> resultByOperation
dmichon-msft be41320
Handle mid-run invalidation of executed operations
dmichon-msft 0b2dfa4
First round cleanup
dmichon-msft 374c3b1
Immutable options object
dmichon-msft 4821a83
Tune up ProjectWatcher
dmichon-msft 15f0237
Update api.md
dmichon-msft 73ba208
Revise watch mode string
dmichon-msft f387420
Fix inaccurate typings on metadataFolderPath
dmichon-msft aaa7579
Update api.md
dmichon-msft 75d3aca
Fix errant dead name
dmichon-msft a984c5b
More hook updates
dmichon-msft 466987f
More feedback
dmichon-msft 1a8437b
Address more feedback
dmichon-msft 864f276
Set startTime if defined
dmichon-msft 289ac41
Support overriding startTime
dmichon-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
common/changes/@microsoft/rush/watch-rework_2025-09-26-23-50.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@microsoft/rush", | ||
| "comment": "(PLUGIN BREAKING CHANGE) Overhaul watch-mode commands such that the graph is only created once at the start of command invocation, along with a stateful manager object. Plugins may now access the manager object and use it to orchestrate and tap into the build process.", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@microsoft/rush" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/rush/v5/rush-serve-plugin-options.schema.json", | ||
| "phasedCommands": ["start"], | ||
| "portParameterLongName": "--port", | ||
| "buildStatusWebSocketPath": "/ws", | ||
| "logServePath": "/logs" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush. | ||
| { | ||
| "pnpmShrinkwrapHash": "8cea08431b1a848463c751666dcd35e9533ea73d", | ||
| "pnpmShrinkwrapHash": "b595f703fea0b5d0ca523cf2bc67e30981b3d0a3", | ||
| "preferredVersionsHash": "029c99bd6e65c5e1f25e2848340509811ff9753c" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.