Fix Focus Outline for Programmatical focus - #16373
Open
Vineeth (vineethkuttan) wants to merge 1 commit into
Open
Fix Focus Outline for Programmatical focus#16373Vineeth (vineethkuttan) wants to merge 1 commit into
Vineeth (vineethkuttan) wants to merge 1 commit into
Conversation
* Remove Focus Outline for Programmatical Focus * Change files * format changes
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Fabric focus visuals appearing during startup-time programmatic focus.
Changes:
- Treats programmatic focus as pointer focus unless preserving keyboard focus.
- Adds a patch changelog entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
vnext/Microsoft.ReactNative/Fabric/Composition/RootComponentView.cpp |
Corrects programmatic focus-state selection. |
change/react-native-windows-85a3d26d-f9c2-4888-9e32-a6a3f9f4a2b9.json |
Adds release-note metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "patch", | |||
| "comment": "Remove Focus Outline for Programmatical Focus", | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a component receives programmatic focus (via autoFocus or ref.focus()) during app startup, the focus outline/rectangle is displayed. This should not happen — programmatic focus should not trigger the focus visual, only keyboard-initiated focus should.
The same component focused programmatically at any other time (e.g., triggered by a button press) correctly does not show the focus outline. The issue is isolated to the initial app start focus.
Type of Change
Bug fix (non-breaking change which fixes an issue)
resolves Focus outline/visual incorrectly shown when element receives focus programmatically on app start #16177
Testing
Tested in playground
Changelog
Should this change be included in the release notes: yes
Fix Focus Outline for Programmatical focus
Microsoft Reviewers: Open in CodeFlow