ci: automate setting npm tags #2803
Open
+162
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Jan 14, 2026
tido64
requested changes
Jan 15, 2026
.ado/scripts/prepublish-check.mjs
Outdated
| console.log(`##vso[task.setvariable variable=additionalTags]${tagsValue}`); | ||
| // GitHub Actions | ||
| if (process.env["GITHUB_OUTPUT"]) { | ||
| fs.appendFileSync(process.env["GITHUB_OUTPUT"], `additionalTags=${tagsValue}\n`); |
Member
There was a problem hiding this comment.
What is this line supposed to do? GITHUB_OUTPUT is an env var. Why are we writing to it as if it's a file?
Collaborator
Author
There was a problem hiding this comment.
Apparently, it's actually an "environment file", that contains key value pairs
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Saadnajmi
force-pushed
the
automate-tags
branch
from
2b75d5a to
c9835c3
Compare
tido64
approved these changes
Jan 16, 2026
| log(`Expected npm tag: ${tag}`); | ||
| return { npmTag: tag }; | ||
| // When promoting to latest, also add the version-specific stable tag | ||
| const versionTag = "v" + branch; |
Comment on lines
-367
to
-369
| // If we're demoting a branch, we will need to create a new tag. This will | ||
| // make Nx trip if we don't specify a fallback. In all other scenarios, the | ||
| // tags should exist and therefore prefer it to fail. |
Member
There was a problem hiding this comment.
Did Nx fix this? Whenever we publish a new minor, wouldn't this still trigger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
One part of our publish process we have not yet automated is setting the
v0.xx-stableandnexttags when a new release is promoted or demoted. Let's automate this by specifying additional tags in our CI that should be set when we publish a release. Now, a newlatestor patch tolatestwill also always set is0.xx-stabletag.Note: Previously, if
0.xxwas tagged aslatest, we would not have had av0.xx-stabletag. Now we will always have bothlatestand the0.xx-stabletag.Test Plan:
I duplicated this change to #2800 and #2801 . We can look at the dry run output for both to make sure release is behaving as expected.