Fix CatBoost and XGBoost evals_result handling - #2327
Open
mrlonely (mameikagou) wants to merge 1 commit into
Open
Fix CatBoost and XGBoost evals_result handling#2327mrlonely (mameikagou) wants to merge 1 commit into
mrlonely (mameikagou) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
mrlonely (mameikagou)
marked this pull request as ready for review
August 19, 2026 11:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix evaluation-result handling in the CatBoost and XGBoost model wrappers.
CatBoostModel.fitnow preserves and updates a caller-providedevals_resultdictionary instead of rebinding the local variable and silently discarding the output.Noneinstead of a mutable dictionary as the default argument.Root cause
CatBoostModel.fitassignedself.model.get_evals_result()to the localevals_resultname. When a caller passed a dictionary, that dictionary was never populated. Both wrappers also declaredevals_result=dict()in the function signature, sharing one dictionary across calls that omit the argument.Impact
Callers can reliably collect train and validation metric histories through the same
evals_resultcontract used by the other Qlib model wrappers. Existing calls that omit the argument remain compatible.Validation
5 passed--target-version py38 --line-length 120): passedRisk
Low. The model training calls and returned model objects are unchanged; the patch only corrects the optional output dictionary and removes mutable defaults.