Add frem, fptoui, uitofp instructions to QIR simulators#3268
Open
orpuente-MS wants to merge 1 commit into
Open
Add frem, fptoui, uitofp instructions to QIR simulators#3268orpuente-MS wants to merge 1 commit into
frem, fptoui, uitofp instructions to QIR simulators#3268orpuente-MS wants to merge 1 commit into
Conversation
joao-boechat
approved these changes
Jun 1, 2026
| ("fsub", 3.0, 10.0, -7.0), | ||
| ("fmul", 6.0, 7.0, 42.0), | ||
| ("fdiv", 8.0, 2.0, 4.0), | ||
| ("frem", 8.0, 2.0, 0.0), |
Contributor
There was a problem hiding this comment.
Should we have test cases where divisor is 0 to make sure it fails gracefully?
Contributor
There was a problem hiding this comment.
Also would be nice to test fptoui with negative floats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
frem,fptoui, anduitofpinstructions to the QIR simulators to handle the codegen changes in #3187 .