Only embed Windows resources for binary targets#374
Merged
karthiknadig merged 1 commit intomicrosoft:mainfrom Mar 17, 2026
Merged
Only embed Windows resources for binary targets#374karthiknadig merged 1 commit intomicrosoft:mainfrom
karthiknadig merged 1 commit intomicrosoft:mainfrom
Conversation
Member
|
The test failure here is because fork don't have write permissions and these pipelines use write to add coverage and perf data. |
karthiknadig
approved these changes
Mar 17, 2026
eleanorjboyd
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #373
Ensures winresource only runs when building binary targets by checking the
CARGO_BIN_NAMEenvironment variable. This prevents resource conflicts when pet is used as a library dependency on Windows.