make tabbing in the monaco editor navigate instead of inserting a character#11351
Draft
srietkerk wants to merge 1 commit into
Draft
make tabbing in the monaco editor navigate instead of inserting a character#11351srietkerk wants to merge 1 commit into
srietkerk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/pxt-microbit#6859
This is a draft PR because this needs to be discussed within the team first. Right now in monaco, the toggle (Ctrl+M) to use tab to continue to navigate the page is available, but the user has to know about it. The default behavior is tabbing will insert a tab in the editor space. The proposition in this issue, and which has been implemented in this PR, is to make "tab navigation mode" be the default in the monaco editor. As in, if the user is focused on the workspace and tab, they will continue to navigate the page rather than insert a tab in the document. I think this is pretty big breaking behavior to have this on by default, but copilot cli did this well earlier, and I figured if we do want to ship this, I should have this available.
Upload target: https://makecode.microbit.org/app/68bc469e9693f2c198f3b1007f0bd65e82f9325f-9ec3d8863d#