pxtarget.json: githubCorePackage bumped from v0.2.13 to v0.3.0#6925
Open
KierPalin wants to merge 1 commit into
Open
pxtarget.json: githubCorePackage bumped from v0.2.13 to v0.3.0#6925KierPalin wants to merge 1 commit into
KierPalin wants to merge 1 commit into
Conversation
…s cmake_minimum_required of utils/cmake/JSONParser.cmake from 3.1 to 3.6; this is important because CMake 4.0.0 deprecates <3.5. This meant that pxt-microbit couldn't be compiled with CMake versions newer than 4.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @abchatra @thomasjball,
This is the aforementioned compilation issue:
CMake 4.0.0+ removed compatibility with versions older than 3.5. This is a problem because the current githubCorePackage is on v0.2.13 which means that the microbit-v2-samples/utils/cmake/JSONParser.cmake has a cmake_minimum_required of 3.1, thus pxt-microbit cannot be compiled when using the latest versions of CMake.
Fortunately, the latest microbit-v2-samples bumps the cmake_minimum_required to 3.6, so we need only update the githubCorePackage to it.
I tested the change by building microcode-v2 and its dependencies with this change and the latest CMake version 4.3.0.
There are a few changes between v0.3.0 and v0.2.13, as visible in this comparison for v0.3.0 and v0.2.13.
Thanks,
Kier