Skip to content

fix(cli): hide Windows daemon consoles - #42155

Merged
Simon Knott (Skn0tt) merged 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-fix-42152
Aug 6, 2026
Merged

fix(cli): hide Windows daemon consoles#42155
Simon Knott (Skn0tt) merged 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-fix-42152

Conversation

@Skn0tt

@Skn0tt Simon Knott (Skn0tt) commented Aug 6, 2026

Copy link
Copy Markdown
Member

Fixes #42152. This fix is scoped to CLI and MCP and /taskkill, so compared to #38776 it should have a much smaller blast radius. In my testing the cli open --headed and cli show commands still worked fine across CMD and PowerShell.

Two constraints that might limit our risk appetite here:

  • this only helps CMD users, PowerShell was already fine in my testing
  • npx has the same bug, so anybody who uses us through npx won't see an improvement

Hide detached CLI and dashboard daemon windows, and prevent taskkill from flashing a console while replacing or closing sessions. Browser process launches remain unchanged so headed mode, Inspector, and UI mode stay visible.\n\nFixes: https://github.com/microsoft/playwright/issues/42152\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: 37896276-261f-4ff0-9664-06aa7dfc471b
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:299 › should report intercepted service worker requests in HAR `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:113 › screencast › should capture static page `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51234 passed, 1190 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-core.spec.ts:57 › click link @mcp-windows-latest-firefox

8049 passed, 1284 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the one failure is a pre-existing Windows-Firefox flake

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

The only real failure is [firefox] › mcp/cli-core.spec.ts:57 › click link on mcp-windows-latest-firefox, and it's a known flake, not something this PR broke. Everything else is flaky/interrupted, which isn't triage-worthy. This PR looks clear.

Details

Overall: no failure traces back to this change. The diff is a small, Windows-only windowsHide: true addition to a few spawn/spawnSync calls, and it doesn't alter the behavior the failing test asserts on.

Pre-existing flake / infra

Not triage-worthy

  • The "tests 1" report is 5 flaky, 0 failed — nothing to look at (browsercontext-page-event.spec.ts:173, chromium.spec.ts:299, video.spec.ts:113 & :699, page-event-request.spec.ts:181, all passed on retry).

Triaged by the Playwright bot - agent run

@Skn0tt
Simon Knott (Skn0tt) merged commit f1fc9fc into microsoft:main Aug 6, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] session daemon opens a console window on Windows

2 participants